Page MenuHomePhabricator

Suppress section edit links with action=render
Closed, ResolvedPublic

Description

action=render is often used to pull the rendered html of an article for inclusion in a different context. more often than not, edit links are not desired in that context. So it would be nice if they could be disabled.


Version: 1.16.x
Severity: enhancement
See Also:
https://bugzilla.wikimedia.org/show_bug.cgi?id=55900

Event Timeline

bzimport raised the priority of this task from to Low.
bzimport set Reference to bz19415.
daniel created this task.Jun 27 2009, 8:03 AM

action=render is now emitting '[edit source | edit]'

https://en.wikipedia.org/wiki/Entomophagy?action=render

There are ~400,000 (BIG NUMBER ALERT) action=render entries in Google Results

https://www.google.com.au/search?q=inurl:action%3Drender%E2%80%8E+site%3Aen.wikipedia.org

As VE does not work unless the user is logged on, and has VE enabled in their prefs (Bug 55900), the 'edit' link to VE will be inoperative for most people who chance upon an action=render link.

Change 94150 had a related patch set uploaded by Bartosz Dziewoński:
Suppress section edit links with action=render

https://gerrit.wikimedia.org/r/94150

Change 94150 merged by jenkins-bot:
Suppress section edit links with action=render

https://gerrit.wikimedia.org/r/94150

Yay, merged!

Also, a note: among other things this affects file description pages imported from a remove repository (I think both with Wikimedia setup with Commons, and with $wgUseInstantCommons) – they would previously show silly section edit links pointing to nowhere if the page had any headings, now they won't. It might also affect things like scary transclusion of pages.

Reverted by Brad in Ie65e3de8, caused section edit links to be shown on views of old revisions.

The bug was also spotted on VPT: https://en.wikipedia.org/w/index.php?oldid=582829813#Section_edit_links_are_appearing_on_diffs

Matma Rex: Do you plan to rework this, or should the 1.23.x TM be removed?

I probably won't do it soon, sorry.

But thanks for reminding me about this, as I realized that bug 62071 is probably a duplicate :)

On the other hand, these links are desired on cases like this:
https://pt.wikipedia.org/wiki/MediaWiki:Gadget-PagesForDeletion.js/Core.js
https://pt.wikipedia.org/wiki/WP:PE/L
(this is the core part of the current AfD workflow on ptwiki)

Is this supposed to be fixed for 1.16?

Change 118135 had a related patch set uploaded by Jdlrobson:
Suppress section edit links with action=render

https://gerrit.wikimedia.org/r/118135

If we enabled/disabled this via a parameter would this be sufficient? Could those gadgets be altered to make use of that parameter?

Yes, a parameter would be sufficient.

Change 118135 merged by jenkins-bot:
Suppress section edit links with action=render

https://gerrit.wikimedia.org/r/118135

I suppose this is fixed again, then. Thanks!

(In reply to Bartosz Dziewoński from comment #4)

Yay, merged!

Also, a note: among other things this affects file description pages
imported from a remove repository (I think both with Wikimedia setup with
Commons, and with $wgUseInstantCommons) – they would previously show silly
section edit links pointing to nowhere if the page had any headings, now
they won't. It might also affect things like scary transclusion of pages.

Not really pointing to nowhere, they actually had gone to the right place