Page MenuHomePhabricator

semantic fingerprint mark-up
Closed, ResolvedPublic

Description

Currently all fingerprint labels are h2.
It does make sense for the primary language label to be marked-up that way (sort of the page title), but all the following ones should not take a semantic hierarchy - could be an agnostic container instead.

<component is="isPrimary ? 'h2' : 'div'">{{ label }}</component>

maybe?

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2019, 4:35 PM
Pablo-WMDE removed Jakob_WMDE as the assignee of this task.Jan 18 2019, 4:35 PM
Pablo-WMDE added a subscriber: Jakob_WMDE.
Jakob_WMDE updated the task description. (Show Details)Jan 18 2019, 4:39 PM
Jakob_WMDE updated the task description. (Show Details)Jan 18 2019, 5:00 PM
Jakob_WMDE moved this task from To Do to Doing on the Wikidata-Termbox-Iteration-7 board.

Change 485214 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Use h2 only for the primary label

https://gerrit.wikimedia.org/r/485214

Change 485214 merged by jenkins-bot:
[wikibase/termbox@master] Use h2 only for the primary label

https://gerrit.wikimedia.org/r/485214

Jakob_WMDE closed this task as Resolved.Jan 28 2019, 3:37 PM