Page MenuHomePhabricator

semantic fingerprint mark-up
Closed, ResolvedPublic

Description

Currently all fingerprint labels are h2.
It does make sense for the primary language label to be marked-up that way (sort of the page title), but all the following ones should not take a semantic hierarchy - could be an agnostic container instead.

<component is="isPrimary ? 'h2' : 'div'">{{ label }}</component>

maybe?

Event Timeline

Change 485214 had a related patch set uploaded (by Jakob; owner: Jakob):
[wikibase/termbox@master] Use h2 only for the primary label

https://gerrit.wikimedia.org/r/485214

Change 485214 merged by jenkins-bot:
[wikibase/termbox@master] Use h2 only for the primary label

https://gerrit.wikimedia.org/r/485214