Page MenuHomePhabricator

Editor code is packaged in 2 modules
Closed, ResolvedPublic5 Estimated Story Points

Description

The code for the editor in MobileFrontend is spread across various ResourceLoader modules - mobile.editor, mobile.editor.api, mobile.editor.common, mobile.editor.overlay and mobile.editor.ve

There is no need for this.

We will switch to two modules:
mobile.editor.ve and mobile.editor.overlay (the former contains VisualEditor extension specific code)

Acceptance criteria

  • There are only 2 editor ResourceLoader modules

Event Timeline

Change 484605 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] All the editor code in one single module

https://gerrit.wikimedia.org/r/484605

Jdlrobson set the point value for this task to 5.Jan 22 2019, 5:17 PM

Change 484605 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] All the editor code in one single module

https://gerrit.wikimedia.org/r/484605

Would you mind signing this off Stephen?

Niedzielski subscribed.

I think this needs more work. mobile.editor is still present in extension.json and tests/qunit/mobile.editor.api/EditorGateway.test.js references mobile.editor.api.

@Jdlrobson, should I create a dependency, move the module consolidation requirements to T213340, make a new task, or remove the requirements?

@Jdlrobson, should I create a dependency, move the module consolidation requirements to T213340, make a new task, or remove the requirements?

Not sure I understand the question. Note, T213340 already has the following acceptance criteria:

  • mobile.editor should be ported to webpack or consider merging into mobile.init if that makes sense