Education dots rendering issues
Closed, ResolvedPublic0.5 Estimated Story Points
Actions

Description

The circles have very slightly flat sides, and the larger circles don't quite centre correctly:

probably because we using em's which generate non-integer pixel values

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	master	+9 -8	Use pixel dimensions for education dots

Customize query in gerrit

Related Objects

Duplicates Merged Here: T117633: The pulse is not aligned properly for pulsating dot for educational pop-up

Event Timeline

Esanders created this task.Jan 18 2019, 8:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 18 2019, 8:58 PM

Change 485254 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use pixel dimensions for education dots

https://gerrit.wikimedia.org/r/485254

gerritbot added a project: Patch-For-Review.Jan 18 2019, 9:01 PM

After:

Esanders set the point value for this task to 0.5.Jan 18 2019, 9:04 PM

Jdforrester-WMF assigned this task to Esanders.Jan 18 2019, 9:13 PM

Jdforrester-WMF edited projects, added MW-1.33-notes (1.33.0-wmf.14; 2019-01-22); removed Patch-For-Review.

Change 485254 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use pixel dimensions for education dots

https://gerrit.wikimedia.org/r/485254

matmarex edited projects, added VisualEditor (Current work); removed VisualEditor.Feb 26 2019, 5:10 PM

matmarex moved this task from Incoming to QA on the VisualEditor (Current work) board.

Ryasmeen added a project: Editing QA.Feb 26 2019, 8:46 PM

Ryasmeen edited projects, added Verified; removed Editing QA.Mar 1 2019, 1:34 AM

Ryasmeen moved this task from QA to Product owner review on the VisualEditor (Current work) board.

Ryasmeen merged a task: T117633: The pulse is not aligned properly for pulsating dot for educational pop-up.Mar 1 2019, 1:37 AM

Ryasmeen added subscribers: Ryasmeen, StudiesWorld.

Hmm. In following the steps below, I seem to still be encountering, "...circles [that] have very slightly flat sides, and the larger circles don't quite centre correctly..."

@Esanders, two questions:

Are you seeing "What I'm seeing"?
Are there steps different from the ones below I should be following to verify this patch fixes what it's been intended to fix?

What I'm seeing

Not-quite-circles.png (556×810 px, 36 KB)

Steps

In Chrome on desktop, open a new incognito window
Navigate to: https://en.wikipedia.org/wiki/Kevin_A._Lynch
Tap edit
Switch to "Visual editing"

Result: ...oblong circles appear

@ppelberg can't close this as he is waiting on a response from @Esanders

You are using a high DPI display (mac) so the rendering is different. I tried 200% zoom in Chrome and they still look round to me. Which browser is this in?

Given that the position and size are now defined in integer pixels this could just be a browser bug...

In T214203#5210435, @Esanders wrote:

You are using a high DPI display (mac) so the rendering is different.

Oh, okay.

I tried 200% zoom in Chrome and they still look round to me. Which browser is this in?

Chrome. I just tried 200% zoom (see below) and I am no longer seeing oblong education dots.

Screen Shot 2019-06-26 at 10.18.52 PM.png (464×696 px, 25 KB)

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 27 2019, 5:20 AM

Education dots rendering issuesClosed, ResolvedPublic0.5 Estimated Story PointsActions