The circles have very slightly flat sides, and the larger circles don't quite centre correctly:
probably because we using em's which generate non-integer pixel values
The circles have very slightly flat sides, and the larger circles don't quite centre correctly:
probably because we using em's which generate non-integer pixel values
Project | Branch | Lines +/- | Subject | |
---|---|---|---|---|
mediawiki/extensions/VisualEditor | master | +9 -8 | Use pixel dimensions for education dots |
Change 485254 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Use pixel dimensions for education dots
Change 485254 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Use pixel dimensions for education dots
Hmm. In following the steps below, I seem to still be encountering, "...circles [that] have very slightly flat sides, and the larger circles don't quite centre correctly..."
@Esanders, two questions:
Result: ...oblong circles appear
You are using a high DPI display (mac) so the rendering is different. I tried 200% zoom in Chrome and they still look round to me. Which browser is this in?
Given that the position and size are now defined in integer pixels this could just be a browser bug...
Oh, okay.
I tried 200% zoom in Chrome and they still look round to me. Which browser is this in?
Chrome. I just tried 200% zoom (see below) and I am no longer seeing oblong education dots.