Maniphest T214356

Fully remove $wgTranslateCC
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Jan 22 2019, 8:43 AM

Project Tags

Referenced Files

None

Subscribers

Description

Fully remove $wgTranslateCC

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove unused global variable $wgTranslateCC	mediawiki/extensions/Translate	master	+2 -26

Customize query in gerrit

Related Objects

Mentioned In: T212836: Deprecate $wgTranslateCC

Event Timeline

Nikerabbit created this task.Jan 22 2019, 8:43 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 8:43 AM

Nikerabbit moved this task from Backlog to 2019.07 on the MediaWiki Language Extension Bundle board.Jan 22 2019, 8:43 AM

Nikerabbit mentioned this in T212836: Deprecate $wgTranslateCC.

Pginer-WMF triaged this task as Medium priority.Jul 2 2019, 9:18 AM

Pginer-WMF added a project: Language-Team (Language-2019-July-September).

Pginer-WMF moved this task from Backlog to Priority backlog on the Language-Team (Language-2019-July-September) board.

https://codesearch.wmflabs.org/search/?q=TranslateCC&i=nope&files=&repos= (do not remove HISTORY entry)

https://github.com/search?q=wgTranslateCC+language%3APHP&type=Code is full of old forks of Translate or mediawiki-config except https://github.com/ligurio/openvz-playbooks/blob/fa613ae7ba13cb9480e3de44d5728d88ea49c2ce/playbooks/roles/mediawiki/files/localsettings/LocalExtensions.php but that repository is archived.

So it should be fully safe to remove it with a release note entry in MLEB

abi_ claimed this task.Jul 10 2019, 8:01 AM

abi_ moved this task from Priority backlog to In Progress on the Language-Team (Language-2019-July-September) board.Jul 10 2019, 11:33 AM

Change 521885 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Remove unused global variable $wgTranslateCC

https://gerrit.wikimedia.org/r/521885

gerritbot added a project: Patch-For-Review.Jul 10 2019, 2:52 PM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2019-July-September) board.Jul 10 2019, 3:15 PM

Change 521885 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Remove unused global variable $wgTranslateCC

https://gerrit.wikimedia.org/r/521885

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.14; 2019-07-16).Jul 15 2019, 1:00 PM

Related patch is merged. Moving this to the appropriate status.

Will resolve if changes due to this do not cause any issues after the train runs.

Since this has been on production since the 16th of this month, and no related issues have been reported marking this as resolved.