Display diffs between Schema versions
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

A user should be able to see a diff between a new version of the Schema vs the old version of the Schema

GIVEN two versions of a Schema
THEN It should be possible to see the diff of them

Acceptance Criteria

There should be a way to view the diff
This diff should be formatted like a Mediawiki diff
Instead of being based on the lines of the underlying JSON, the diff should focus on the structure of the schema (Wikidata example)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/WikibaseSchema	master	+442 -6	Add WikibaseSchemaSlotDiffRenderer
	mediawiki/extensions/WikibaseSchema	master	+156 -0	Add SchemaDiffer

Customize query in gerrit

Event Timeline

noarave created this task.Jan 22 2019, 3:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 3:03 PM

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Jan 28 2019, 10:22 AM

Lucas_Werkmeister_WMDE edited projects, added Shape Expressions Sprint 1; removed Shape Expressions.Jan 28 2019, 10:25 AM

Current state: https://wikidata-shex.wmflabs.org/w/index.php?title=Schema:O1&diff=17&oldid=10

Ladsgroup moved this task from incoming to in progress on the Wikidata board.Jan 30 2019, 1:33 PM

hoo claimed this task.Feb 6 2019, 2:18 PM

hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 1 board.

Change 489256 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] Add SchemaDiffer

https://gerrit.wikimedia.org/r/489256

gerritbot added a project: Patch-For-Review.Feb 8 2019, 4:56 PM

Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 2.Feb 11 2019, 2:13 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 2 board.

hoo removed hoo as the assignee of this task.Feb 13 2019, 5:04 PM

hoo moved this task from Doing to Backlog on the Shape Expressions Sprint 2 board.

hoo added a subscriber: hoo.

Change 489256 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add SchemaDiffer

https://gerrit.wikimedia.org/r/489256

Lucas_Werkmeister_WMDE claimed this task.Feb 14 2019, 4:01 PM

Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 2 board.

Change 490676 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseSchema@master] WIP: Add WikibaseSchemaSlotDiffRenderer

https://gerrit.wikimedia.org/r/490676

Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Feb 14 2019, 7:24 PM

Lucas_Werkmeister_WMDE added a subscriber: Lucas_Werkmeister_WMDE.

Screenshots of the WIP patch:

I unassigned myself because I’m on vacation for the next week, so I hope others will be able to take over the patch (and not be too appalled at my code).

noarave moved this task from Doing to Peer Review on the Shape Expressions Sprint 2 board.Feb 18 2019, 10:47 AM

Change 490676 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add WikibaseSchemaSlotDiffRenderer

https://gerrit.wikimedia.org/r/490676

Tarrow moved this task from Peer Review to Verification on the Shape Expressions Sprint 2 board.Feb 20 2019, 10:46 AM

\o/

Lucas_Werkmeister_WMDE set the point value for this task to 8.Feb 25 2019, 2:09 PM

Display diffs between Schema versionsClosed, ResolvedPublic8 Estimated Story PointsActions

Description

Details

Event Timeline

Display diffs between Schema versions
Closed, ResolvedPublic8 Estimated Story Points
Actions