Gerrit: reviewers-by-blame plugin improvements
Closed, DeclinedPublic
Actions

Assigned To

None

Authored By

	thcipriani
	Jan 22 2019, 3:07 PM

Description

The thread on wikitech-l from January 2019 contains suggestions for improvement for the reviewers-by-blame plugin. This task is meant to surface those suggestions in an actionable form.

It may be useful to collect all improvements, and use those to inform plugin requirements.

Improvements

Ensure reviewers aren't re-added once removed (#10339)
Opt out via user config from being added as a reviewer
User initiated adding of reviewers rather than auto-adding reviewers
- add a button for adding reviewers instead (#10337/r211052)
- or add them to the suggested reviewers list instead
Attribute reviewer-by-blame requests to a bot user (#10328/r211189)
Get reviewers based on who CR+2-d the touched lines, not just who authored them (#10340)

Other upstream reports/patches

Opt out certain users (libraryuploader etc.) via repo config from being added as a reviewer (#10318/r210812)
Limit the feature (or parts of it) to changesets uploaded by new users (#10345)

Related Objects
Search...

Status	Assigned	Task
Declined	None	T214397 Gerrit: reviewers-by-blame plugin improvements
Declined	Paladox	T213997 Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin
Declined	None	T214097 reviewers-by-blame plugin: only recent reviewers should be pinged

Event Timeline

thcipriani created this task.Jan 22 2019, 3:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 3:08 PM

thcipriani triaged this task as Medium priority.Jan 22 2019, 3:08 PM

thcipriani moved this task from Bugs & stuff to Discussions & doc stuff on the Gerrit board.

Zppix subscribed.Jan 22 2019, 3:09 PM

hashar updated the task description. (Show Details)Jan 22 2019, 5:39 PM

hashar subscribed.

MGChecker subscribed.Jan 22 2019, 6:58 PM

I support "Get reviewers based on paste code-reviews votes"
Use Code-Review+1/+2/-1/-2 to find new reviewers, because that would let people review the code and repository which already does it. Using git blame and searching for authors must not find people able to merge patch sets. With the Code-Review that is possible.

Inspired by hashar's blog Blog Post: Gerrit now automatically adds reviewers section "Past reviewers from git notes"

Options to opt-out for users at all and for repos sounds good.

Paladox updated the task description. (Show Details)Jan 22 2019, 11:03 PM

Removed Ensure reviewers aren't re-added every patchset which seems like a duplicate of Ensure reviewers aren't re-added once removed.

Tgr updated the task description. (Show Details)Jan 26 2019, 12:37 AM

Tgr updated the task description. (Show Details)Jan 26 2019, 12:42 AM

Tgr added a subtask: T213997: Exempt libraryupgrader from Gerrit's reviewers-by-blame plugin.

Tgr added a subtask: T214097: reviewers-by-blame plugin: only recent reviewers should be pinged.

Rephrased/split the opt-out functionality. I don't think a blacklist that must be configured per-repo by the repo admins is a reasonable replacement for users to be able to opt out via their user configuration.

greg moved this task from INBOX to Backlog on the Release-Engineering-Team board.Mar 5 2019, 12:42 AM

greg edited projects, added Release-Engineering-Team (Backlog); removed Release-Engineering-Team.

• Phabricator_maintenance edited projects, added Release-Engineering-Team-TODO; removed Release-Engineering-Team (Backlog).Jun 12 2019, 11:52 PM

• Phabricator_maintenance moved this task from Should be empty (use Release-Engineering-Team) to Later / Need volunteer on the Release-Engineering-Team-TODO board.Jun 12 2019, 11:55 PM

greg added a project: Release-Engineering-Team.Jun 21 2019, 10:35 PM

greg edited projects, added Release-Engineering-Team (Development services); removed Release-Engineering-Team.Jun 24 2019, 7:51 PM

Tgr mentioned this in T229513: Define tools/processes to help manage code reviews.Aug 5 2019, 7:23 AM

The reviewers-by-blame plugin has been removed and is extremely unlikely to be used again in its current state. Adding reviewers based on last author/committer does not quite identify an appropriate reviewer in our workflows.

@Tgr I have declined all tasks. Thank you though for all the feedback and tasks you have filed at the time we had the plugin enabled, much appreciated. All over, it does not seem the plugin is any appropriate for our workflows :]

hashar moved this task from Discussions & doc stuff to Bugs & stuff on the Gerrit board.Mar 1 2023, 10:55 AM

Tgr mentioned this in T333010: [Session] Using automated systems to recommend reviewers in the MediaWiki project.May 16 2023, 4:18 AM

Gerrit: reviewers-by-blame plugin improvementsClosed, DeclinedPublicActions