Page MenuHomePhabricator

Gerrit: reviewers-by-blame plugin improvements
Open, MediumPublic

Description

The thread on wikitech-l from January 2019 contains suggestions for improvement for the reviewers-by-blame plugin. This task is meant to surface those suggestions in an actionable form.

It may be useful to collect all improvements, and use those to inform plugin requirements.

Improvements

  • Ensure reviewers aren't re-added once removed (#10339)
  • Opt out via user config from being added as a reviewer
  • User initiated adding of reviewers rather than auto-adding reviewers
    • add a button for adding reviewers instead (#10337/r211052)
    • or add them to the suggested reviewers list instead
  • Attribute reviewer-by-blame requests to a bot user (#10328/r211189)
  • Get reviewers based on who CR+2-d the touched lines, not just who authored them (#10340)

Other upstream reports/patches

  • Opt out certain users (libraryuploader etc.) via repo config from being added as a reviewer (#10318/r210812)
  • Limit the feature (or parts of it) to changesets uploaded by new users (#10345)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 3:08 PM
thcipriani triaged this task as Medium priority.Jan 22 2019, 3:08 PM
thcipriani moved this task from Bugs & stuff to Discussions & doc stuff on the Gerrit board.
Zppix added a subscriber: Zppix.Jan 22 2019, 3:09 PM
hashar updated the task description. (Show Details)Jan 22 2019, 5:39 PM
hashar added a subscriber: hashar.

I support "Get reviewers based on paste code-reviews votes"
Use Code-Review+1/+2/-1/-2 to find new reviewers, because that would let people review the code and repository which already does it. Using git blame and searching for authors must not find people able to merge patch sets. With the Code-Review that is possible.

Inspired by hashar's blog Blog Post: Gerrit now automatically adds reviewers section "Past reviewers from git notes"

Options to opt-out for users at all and for repos sounds good.

Paladox updated the task description. (Show Details)Jan 22 2019, 11:03 PM
Tgr updated the task description. (Show Details)Jan 26 2019, 12:32 AM
Tgr added a subscriber: Tgr.

Removed Ensure reviewers aren't re-added every patchset which seems like a duplicate of Ensure reviewers aren't re-added once removed.

Tgr updated the task description. (Show Details)Jan 26 2019, 12:37 AM
Tgr updated the task description. (Show Details)Jan 26 2019, 12:52 AM

Rephrased/split the opt-out functionality. I don't think a blacklist that must be configured per-repo by the repo admins is a reasonable replacement for users to be able to opt out via their user configuration.