Page MenuHomePhabricator

Malformed HTML markup of moved paragraphs in diffs
Closed, ResolvedPublic

Description

When I visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Special:MobileDiff/388527#movedpara_3_1_rhs

I see the following HTML in the source:

<a class="mw-diff-movedpara-right data-title-tag=" new"="" href="#movedpara_1_1_lhs">▲</a>

Expected:

<a class="mw-diff-movedpara-right new" data-title-tag="  href="#movedpara_1_1_lhs">▲</a>

This is not a problem in the desktop code.
See https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Moving_content&diff=388527

Event Timeline

Change 486092 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/php/wikidiff2@master] Add missing closing double quotes

https://gerrit.wikimedia.org/r/486092

Thanks for the quick response @thiemowmde !

Change 486092 merged by jenkins-bot:
[mediawiki/php/wikidiff2@master] Add missing closing double quotes

https://gerrit.wikimedia.org/r/486092

Lea_WMDE closed this task as Resolved.Feb 6 2019, 1:53 PM
Lea_WMDE claimed this task.
Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-01-23 board.