Page MenuHomePhabricator

Release new version of mediawiki/oauthclient
Closed, ResolvedPublic

Description

There have been 22 commits since the last release (0.1.2) https://github.com/wikimedia/mediawiki-oauthclient-php/releases

I think the next version number should be 0.2.0.

Details

Related Gerrit Patches:

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 22 2019, 9:22 PM
Tgr added a subscriber: Tgr.Jan 22 2019, 10:49 PM

I think the next version number should be 0.2.0.

It will have to be since the PHP version has been bumped.

We should probably bump it again to a supported version first, though, to avoid having to a separate major release for that. The CI libraries it uses probably already don't work with PHP 5.

Good point. I can make a patch for that. To PHP 7.1? And should it keep testing on hhvm?

Change 485970 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/oauthclient-php@master] Update required PHP version and dependencies

https://gerrit.wikimedia.org/r/485970

Tgr added a comment.Jan 22 2019, 11:21 PM

To 5.6.99 which in practice means "PHP7 or HHVM". I don't think you can bump to 7.1 while still supporting HHVM, and then you get into all kinds of trouble on the Wikimedia infrastructure.

Interesting; does that mean that HHVM identifies itself as 5.6.x?

I'm sort of confused now... why do we need to update the required PHP version at all? It doesn't look like any of the changes require it.

Tgr added a comment.Jan 23 2019, 12:07 AM

5.6.99-hhvm, yes.

mediawiki-codesniffer 20+ needs PHP 7 or HHVM to run and checks the code against that syntax. It is not strictly necessary to update because of that, but it does make life simpler.

Change 485970 merged by jenkins-bot:
[mediawiki/oauthclient-php@master] Update required PHP version and dependencies

https://gerrit.wikimedia.org/r/485970

Change 485999 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/oauthclient-php@master] Drop minus-x back a version to avoid PHP7.1 incompatibility

https://gerrit.wikimedia.org/r/485999

Change 485999 merged by jenkins-bot:
[mediawiki/oauthclient-php@master] Drop minus-x back a version to avoid PHP7.1 incompatibility

https://gerrit.wikimedia.org/r/485999

Tgr added a comment.Jan 23 2019, 6:22 AM

Tagging a new release is described at https://www.mediawiki.org/wiki/Gerrit/Troubleshooting#Tagging_an_extension_doesn't_work (or at least if there's less obscure documentation I didn't find it). We don't have release notes / history so no need to update any code (unless you want to add one :).

I made https://gerrit.wikimedia.org/r/c/mediawiki/oauthclient-php/+/485994 as an attempt at a changelog. If we merge that, I'll tag 1.0.0 today.

Tgr awarded a token.Jan 23 2019, 8:25 PM