Most page views currently have the following deprecation notice emitted in the console;
This page is using the deprecated ResourceLoader module "schema.ReadingDepth".
See https://phabricator.wikimedia.org/T205744 for migration info.
There is also a dedicated network request created for this one, which is a roundtrip holding back the window load event with a full roundtrip, only to log a deprecation message.
mw.loader.implement("schema.ReadingDepth@1wjvpdp",.. mw.log.warn("This page is using the deprecated ResourceLoader module \"schema.ReadingDepth\".\nSee https://phabricator.wikimedia.org/T205744 for migration info."); });
The migration guide for this is at T205744, which contains code samples as well.
I note though, that @phuedx was ahead of this and already migrated the instrumentation to mw.track a while back (f28f1f5f141a9). However, that change left the schema module behind, which is normally ELs responsibility to load when using mw.track(). Since then, I've worked with Analytics to optimise away the need for these modules, hence the request is now empty (T187207).
Acceptance criteria
- No such deprecation message appears in the JavaScript console
- i.e. the ReadingDepth instrumentation no longer loads the deprecated schema.ReadingDepth RL module (per https://phabricator.wikimedia.org/T214444#4954313)
- The ReadingDepth schema's talk page is updated with a note about this change
- Since we're removing the dedicated network request which blocks the logging of the first ReadingDepth event (because it blocks the window load event), this may impact future analysis.
QA steps
- Open the developer console and tag "preserve logs" in the network tab.
- Clear the list of network requests.
- Type "ReadingDepth" in the filter
- Scroll the page and click a link
- Verify that requests to http://reading-web-staging.wmflabs.org/event.gif that contain ReadingDepth are showing up (if you are using the filter they should be the only ones you see)
- Open the developer console and observe that there are no deprecation warnings like the following:
This page is using the deprecated ResourceLoader module "schema.ReadingDepth"
QA Results
Status | Details |
✅ Passed | T214444#4954313 |