Page MenuHomePhabricator

Add tests for the wikidiff2 inline code
Closed, ResolvedPublic1 Estimated Story Points

Description

Currently there are no tests on for the InlineDiff code in the wikidiff2 extension. This lead to the error reported in T214435.

The tests should be extended to check the inline diff output for every provided test case in /tests/.

Event Timeline

Change 820542 had a related patch set uploaded (by TK-999; author: TK-999):

[mediawiki/php/wikidiff2@master] Verify inline diff output in test cases where relevant

https://gerrit.wikimedia.org/r/820542

thiemowmde moved this task from Incoming to In progress on the WMDE-TechWish-Maintenance board.
thiemowmde set the point value for this task to 2.

Change 820542 merged by jenkins-bot:

[mediawiki/php/wikidiff2@master] Verify inline diff output in test cases where relevant

https://gerrit.wikimedia.org/r/820542

thiemowmde changed the point value for this task from 2 to 1.Fri, Aug 5, 9:37 AM

@WMDE-Fisch, you created this ticket once. Can you check if the patch solves it sufficiently and close it?

WMDE-Fisch moved this task from Tech Review to Done on the WMDE-TechWish-Sprint-2022-08-03 board.

Fine for me. Thanks!