| • Charlotte | |
| Jan 23 2019, 6:21 PM |
| F28310052: Screenshot_20190301-161210.jpg | |
| Mar 1 2019, 3:21 PM |
| F28163289: Screenshot_20190209-020205.png | |
| Feb 9 2019, 1:05 AM |
| F28163231: Screenshot_20190208-164346.png | |
| Feb 9 2019, 12:58 AM |
| F28163229: Screenshot_20190208-164332.png | |
| Feb 9 2019, 12:58 AM |
| F28016717: My lists search 06.png | |
| Jan 24 2019, 4:23 PM |
| F28016715: My lists search 05.png | |
| Jan 24 2019, 4:23 PM |
| F28013735: My lists search 06.png | |
| Jan 24 2019, 11:39 AM |
| F28013733: My lists search 05.png | |
| Jan 24 2019, 11:39 AM |
👉 Search in “My lists“ | T214506 on Zeplin
https://overflow.io/s/QEVP3O/?node=72a041d1
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Contextual actions for list item | apps/android/wikipedia | master | +688 -413 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | scblr | T188333 [EPIC] Allow users to search for articles across all reading lists | |||
| Resolved | cooltey | T214506 Contextual actions for list item |
Change 487980 had a related patch set uploaded (by Cooltey; owner: Cooltey):
[apps/android/wikipedia@master] [WIP] Contextual actions for list item
Hi @schoenbaechler, I have a question regarding the bottom dialog when clicking on the overflow menu of an "article" list item.
As the screenshots below, I have an article "Ricki Lake" saved in two lists (as shown in the red rectangle)
When searching "Ricki" and it will show only one result on the list (T214504), but the "remove article" function in the bottom dialog will only allow the user to remove from a single list once.
My question is, how should the flow be done if the article exists in multiple lists? Should it pop up a dialog that allows the user to pick the lists to be removed from?
+1 to this idea since this dialog already exists when a user taps to unsave an article on multiple reading lists from the Explore feed:
IIRC @Sharvaniharan worked on this back in the day.
+2 - @schoenbaechler, can you sketch out the flow for this? We can re-use the concept @RHo posted above I think.
+3 @cooltey @Charlotte @RHo – updated the flow and screens on Zeplin to represent these enhancements. Used the original designs for the “Remove from reading lists“ dialog and design the feature. I’m not quite sure why the actual implementation is designed differently. @cooltey feel free to use the component design that is already in use.
Thanks @schoenbaechler, @Charlotte and @RHo
For the following, would you recommend to also update the design of removing from reading lists dialog in the Explore feed to be as the same as the design in Zeplin?
I’m not quite sure why the actual implementation is designed differently.
@cooltey please use the same design that is already in use in the explore feed. A redesign of it is not in the scope, I’ll think about filing a task that addresses this difference in design/implementation. Thanks!
Change 487980 abandoned by Cooltey:
Contextual actions for list item
Reason:
Moved to GitHub
Thanks @cooltey, feedback below.
Can we use Roboto Regular instead of Medium for the list names (Saved, People, etc) in this view:
Everything’s too bold currently.
Moving it back to “Did not pass QA“ for now. Thanks.