Page MenuHomePhabricator
Create Task
Maniphest T214606

Regression: Wikidata descriptions are always printed as "1" for tagline
Closed, ResolvedPublic
Actions

Description

Visit https://en.wikipedia.beta.wmflabs.org/wiki/Albert_Einstein
Notice the tagline is "1"

Not a problem on https://fr.m.wikipedia.org/wiki/Saint-P%C3%A9tersbourg
but is a problem on https://en.wikivoyage.org/wiki/Singapore
and http://en-reading-web-staging.wmflabs.org/w/index.php?title=T173949&mobileaction=beta

(Note: Cannot replicate locally.... Remember the Wikidata description rendering via the ContentProvider does not quite follow the same code path, so we may need reading web staging and the wikidata instance there to replicate this problem)

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/MobileFrontendwmf/1.33.0-wmf.14+3 -1If wikidatadata description exists, set it as tagline
mediawiki/extensions/MobileFrontendmaster+3 -1If wikidatadata description exists, set it as tagline
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Jan 24 2019, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2019, 5:29 PM
Jdlrobson triaged this task as High priority.Jan 24 2019, 5:29 PM
Jdlrobson added projects: Regression, MinervaNeue.
Niedzielski added a subscriber: Niedzielski.Jan 24 2019, 5:30 PM
gerritbot added a subscriber: gerritbot.Jan 24 2019, 6:35 PM

Change 486343 had a related patch set uploaded (by Pmiazga; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@master] If wikidatadata description exists, set it as tagline

https://gerrit.wikimedia.org/r/486343

gerritbot added a project: Patch-For-Review.Jan 24 2019, 6:35 PM
gerritbot added a comment.Jan 24 2019, 6:51 PM

Change 486343 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] If wikidatadata description exists, set it as tagline

https://gerrit.wikimedia.org/r/486343

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 24 2019, 7:01 PM
Jdlrobson moved this task from To Do to Ready for Signoff on the Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Jan 24 2019, 8:29 PM
gerritbot added a comment.Jan 24 2019, 10:25 PM

Change 486392 had a related patch set uploaded (by Jdlrobson; owner: Pmiazga):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.14] If wikidatadata description exists, set it as tagline

https://gerrit.wikimedia.org/r/486392

gerritbot added a comment.Jan 25 2019, 12:23 AM

Change 486392 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.14] If wikidatadata description exists, set it as tagline

https://gerrit.wikimedia.org/r/486392

Stashbot added a subscriber: Stashbot.Jan 25 2019, 12:34 AM

Mentioned in SAL (#wikimedia-operations) [2019-01-25T00:34:05Z] <ebernhardson@deploy1001> Synchronized php-1.33.0-wmf.14/extensions/MobileFrontend/: SWAT T214606 gerrit:486392: MobileFrontend if wikidatadata description exists, set it as tagline (duration: 00m 47s)

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.14; 2019-01-22); removed MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 25 2019, 1:01 AM
ovasileva closed this task as Resolved.Jan 30 2019, 12:37 AM
ovasileva claimed this task.
ovasileva added a subscriber: ovasileva.

All done here. Descriptions are back to what they were.

Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL