Page MenuHomePhabricator

Title should not use Action
Closed, ResolvedPublic


Action depends on Title for permission checks, so Title should not depend on Action. (Also Action is a controller type class so it should not be used as a dependency in general.)

Title uses Action::requiresUnblock() which is just a return true; or return false; in all cases and there is no good reason for it to be in Action. It should be turned into a configuration setting, registry or similar object. If we had a PermissionManager (T208768) it could live there, or if we had a BlockFactory it could live there, but right now we don't have any good place for it so probably just going with a global config variable is best.