Page MenuHomePhabricator
Create Task
Maniphest T214632

Tests should detect colons in wgExtraNamespaces
Closed, ResolvedPublic
Actions

Description

Tests of operations/mediawiki-config repo should have detected the colon in that patch:
https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/486221/5/wmf-config/InitialiseSettings.php

Details

ProjectBranchLines +/-Subject
operations/mediawiki-configmaster+7 -9[tests] wgExtraNamespaces should not contain colons
Customize query in gerrit

Event Timeline

Framawiki created this task.Jan 24 2019, 8:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 24 2019, 8:03 PM
Framawiki renamed this task from Tests should detect colons in namespace names dict to Tests should detect colons in wgExtraNamespaces.Jan 24 2019, 8:55 PM
gerritbot added a subscriber: gerritbot.Jan 24 2019, 9:02 PM

Change 486382 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[operations/mediawiki-config@master] [tests] wgExtraNamespaces should not contain colons

https://gerrit.wikimedia.org/r/486382

gerritbot added a project: Patch-For-Review.Jan 24 2019, 9:02 PM
Ammarpad added a subscriber: Ammarpad.Jan 25 2019, 9:35 AM

@Framawiki So it turns out, that was not colon actually. See https://en.wikipedia.org/w/index.php?title=%E0%A4%83&redirect=no where the mark was redirected to Visarga. Then note the actual colon (:) redirect page here: https://en.wikipedia.org/w/index.php?title=%EF%B9%95&redirect=no. This shows their distinctness.

Kizule updated the task description. (Show Details)Jan 26 2019, 11:01 AM
Framawiki moved this task from Backlog to Working on on the Wikimedia-Site-requests board.Jan 26 2019, 8:08 PM
Framawiki claimed this task.Jan 26 2019, 8:18 PM
Framawiki moved this task from Working on to To deploy on the Wikimedia-Site-requests board.Apr 20 2019, 9:55 AM
In T214632#4908359, @Ammarpad wrote:

@Framawiki So it turns out, that was not colon actually. See https://en.wikipedia.org/w/index.php?title=%E0%A4%83&redirect=no where the mark was redirected to Visarga. Then note the actual colon (:) redirect page here: https://en.wikipedia.org/w/index.php?title=%EF%B9%95&redirect=no. This shows their distinctness.

Thank you for the explanation. But these tests may be useful in another case, so I'll push them.

gerritbot added a comment.Apr 29 2019, 6:03 PM

Change 486382 had a related patch set uploaded (by Framawiki; owner: Framawiki):
[operations/mediawiki-config@master] [tests] wgExtraNamespaces should not contain colons

https://gerrit.wikimedia.org/r/486382

gerritbot added a comment.Apr 29 2019, 6:14 PM

Change 486382 merged by jenkins-bot:
[operations/mediawiki-config@master] [tests] wgExtraNamespaces should not contain colons

https://gerrit.wikimedia.org/r/486382

Framawiki closed this task as Resolved.Apr 29 2019, 6:26 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL