Page MenuHomePhabricator

The extension api seems to want a dom-diff-handler
Closed, ResolvedPublic

Event Timeline

ssastry triaged this task as Medium priority.Apr 22 2019, 1:25 PM
ssastry edited projects, added Parsoid-Read-Views-Deprecated-Project; removed Parsoid.

I don't know if it needs direct access to dom diff. But if it recursively invokes the serializer for a subtree, it should be a SelectiveSerializer; ie we should be doing selser and domdiff on that subtree. And we should be smart enough that if a subtree of an extension tag mismatches, we should pop up and reserialize the entire extension tag (using the extension tag's handler), not try to splice it in ourselves.

Change 735080 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Add a method for extensions to diff nodes

https://gerrit.wikimedia.org/r/735080

Change 735457 had a related patch set uploaded (by Arlolra; author: Arlolra):

[mediawiki/services/parsoid@master] [WIP] Implement diffNodes for Cite extension

https://gerrit.wikimedia.org/r/735457

Change 735080 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Add an experimental method for extensions to diff nodes

https://gerrit.wikimedia.org/r/735080

Change 738988 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a10

https://gerrit.wikimedia.org/r/738988

Change 738988 merged by jenkins-bot:

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a10

https://gerrit.wikimedia.org/r/738988

Change 735457 merged by jenkins-bot:

[mediawiki/services/parsoid@master] Implement diffHandler for Cite extension

https://gerrit.wikimedia.org/r/735457

Change 742570 had a related patch set uploaded (by Sbailey; author: Sbailey):

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a11

https://gerrit.wikimedia.org/r/742570

Change 742570 merged by jenkins-bot:

[mediawiki/vendor@master] Bump Parsoid to 0.15.0-a11

https://gerrit.wikimedia.org/r/742570