Page MenuHomePhabricator

Remove hacky EventLogging-duplicating code and use new lightweight EL facilities
Open, Needs TriagePublic4 Story Points

Description

EL now provides more lightweight facilities that we can use! :) See T187207#4902806.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2019, 5:13 PM

Ooh, nice! I think @Jdrewniak said that the portal was duplicating the same code to do some eventlogging outside of mediawiki. Wonder if the new stuff can help them?

@Ejegg The portals are an independent static site, not directly based on MediaWiki. They can certainly use the new lightweight client as basis for their code and/or copy it as-is, but I believe that's effectively what they have done already. Theirs was already "lightweight" in that it had no dependencies and didn't involve fetching schemas from Meta-Wiki for debugging purposes.

Change 508906 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/FundraiserLandingPage@master] Remove temporary EventLogging code-duplication

https://gerrit.wikimedia.org/r/508906

I forgot that there there was a task for this. I've done this for one of your extensions at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FundraiserLandingPage/+/508906/, because it was blocking https://gerrit.wikimedia.org/r/508903 :)

Change 508906 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Remove temporary EventLogging code-duplication

https://gerrit.wikimedia.org/r/508906

Just to note, the new impression event pipeline (see T183978) is broken, since wgEventLoggingBaseUri was removed from global export. The solution is indeed to make the changes described in this task.