Page MenuHomePhabricator

Remove hacky EventLogging-duplicating code and use new lightweight EL facilities
Open, NormalPublic4 Story Points


EL now provides more lightweight facilities that we can use! :) See T187207#4902806.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 25 2019, 5:13 PM

Ooh, nice! I think @Jdrewniak said that the portal was duplicating the same code to do some eventlogging outside of mediawiki. Wonder if the new stuff can help them?

@Ejegg The portals are an independent static site, not directly based on MediaWiki. They can certainly use the new lightweight client as basis for their code and/or copy it as-is, but I believe that's effectively what they have done already. Theirs was already "lightweight" in that it had no dependencies and didn't involve fetching schemas from Meta-Wiki for debugging purposes.

Change 508906 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/extensions/FundraiserLandingPage@master] Remove temporary EventLogging code-duplication

I forgot that there there was a task for this. I've done this for one of your extensions at, because it was blocking :)

Change 508906 merged by jenkins-bot:
[mediawiki/extensions/FundraiserLandingPage@master] Remove temporary EventLogging code-duplication

Just to note, the new impression event pipeline (see T183978) is broken, since wgEventLoggingBaseUri was removed from global export. The solution is indeed to make the changes described in this task.

Krinkle triaged this task as Normal priority.Jul 24 2019, 4:13 PM
Krinkle moved this task from Limbo to Perf recommendation on the Performance-Team (Radar) board.

Change 534222 had a related patch set uploaded (by AndyRussG; owner: AndyRussG):
[mediawiki/extensions/CentralNotice@master] Use EventLogging API directly for impression event

Change 534222 merged by jenkins-bot:
[mediawiki/extensions/CentralNotice@master] Use EventLogging API directly for impression event

This is included in 1.34.0-wmf.22, but because of a train delay, it hasn't been deployed to the group 2 (which includes Wikipedia). However, I've verified that it's working on other production wikis.