Page MenuHomePhabricator
Create Task
Maniphest T214716

Block is incorrectly applied if partial block feature is enabled then disabled
Closed, DeclinedPublic
Actions

Description

Steps to reproduce (requires ability to change wiki configs):

  • with partial blocks enabled, set partial block on a user
  • disable partial blocks, then reblock the user with a sitewide block

Expected: the user is sitewide blocked
Actual: the user's partial block is still applied

There is a work-around, which is to unblock the user, then set the sitewide block. However, if the person making the block does not know to do this, then they will incorrectly think they have applied a sitewide block.

Related Objects

Event Timeline

Tchanders created this task.Jan 25 2019, 6:59 PM
Restricted Application added subscribers: MGChecker, Aklapper. · View Herald TranscriptJan 25 2019, 6:59 PM
• TBolliger renamed this task from Block is incorrectly applied if partial blocks is enabled then disabled to Block is incorrectly applied if partial block feature is enabled then disabled.Jan 25 2019, 7:19 PM
• TBolliger triaged this task as Lowest priority.
• TBolliger moved this task from Untriaged to Product/Tech backlog on the Anti-Harassment-Team board.
• TBolliger subscribed.

We discussed this back in June (!?) with our original database changes. If we get to the point where we have to disable Partial Blocks on a specific wiki we will work with the local admins to manually decide if those users should be sitewide blocks or entirely unblocked.

Tchanders added a comment.Jan 25 2019, 8:05 PM

Thanks @TBolliger. Just to (probably over-) clarify, if we're ever in that situation and the admins do decide that any partially blocked users should be sitewide blocked, they'll have to make sure they unblock them first before setting a new sitewide block... Simply editing their partial block into a sitewide one won't work.

Reedy mentioned this in T214763: Deleting a page that is part of a partial block causes problems.Jan 26 2019, 3:03 PM
• TBolliger closed this task as Declined.Jan 30 2019, 10:08 PM

Won't fix.

Tchanders mentioned this in T250427: Create #MediaWiki-Blocks component.Apr 20 2020, 10:26 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits