Page MenuHomePhabricator
Create Task
Maniphest T214748

SearchInputWidget removes entry on click instead of mouseup on clear button
Closed, ResolvedPublic
Actions

Description

SearchInputWidget is catching the first click on clear button in its input field to delete contents.
It should rather delete on mouse up in order to be able to move out when button got fail clicked.

Details

SubjectRepoBranchLines +/-
Update OOUI to v0.31.1mediawiki/coremaster+977 -819
SearchInputWidget: Use click handler for indicatoroojs/uimaster+6 -2
Customize query in gerrit

Event Timeline

Volker_E created this task.Jan 26 2019, 2:41 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 26 2019, 2:41 AM
gerritbot subscribed.Mar 20 2019, 3:46 PM

Change 496869 had a related patch set uploaded (by Jforrester; owner: Esanders):
[oojs/ui@master] SearchInputWidget: Use click handler for indicator

https://gerrit.wikimedia.org/r/496869

gerritbot added a project: Patch-For-Review.Mar 20 2019, 3:46 PM
Volker_E moved this task from Backlog to Reviewing on the OOUI board.Mar 20 2019, 3:49 PM
gerritbot added a comment.Mar 20 2019, 3:53 PM

Change 496869 merged by jenkins-bot:
[oojs/ui@master] SearchInputWidget: Use click handler for indicator

https://gerrit.wikimedia.org/r/496869

Volker_E moved this task from Reviewing to OOUI-0.31.1 on the OOUI board.Mar 21 2019, 5:23 AM
Volker_E edited projects, added OOUI (OOUI-0.31.1); removed OOUI.
gerritbot added a comment.Mar 21 2019, 4:15 PM

Change 498143 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

Jdforrester-WMF closed this task as Resolved.Mar 22 2019, 4:55 PM
Jdforrester-WMF claimed this task.
Jdforrester-WMF removed a project: Patch-For-Review.
gerritbot added a comment.Mar 22 2019, 7:13 PM

Change 498143 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.31.1

https://gerrit.wikimedia.org/r/498143

Jdforrester-WMF reassigned this task from Jdforrester-WMF to Esanders.Mar 22 2019, 7:20 PM
Jdforrester-WMF added a project: MW-1.33-notes (1.33.0-wmf.23; 2019-03-26).
Jdforrester-WMF subscribed.

This patch landed in MediaWiki master in time for 1.33.0-wmf.23, which will go out to Wikimedia production from 2019-03-26.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL