Page MenuHomePhabricator
Create Task
Maniphest T214807

Patch zuul to remove /p/ from /info/refs call
Closed, ResolvedPublic
Actions

Description

We need to remove /p/ from https://github.com/openstack-infra/zuul/blob/2.6.0/zuul/connection/gerrit.py#L411 seeing as in gerrit 2.16 /p/<project>/info/refs breaks but it works when removing /p/ from the url.

Details

ProjectBranchLines +/-Subject
integration/zuuldebian/jessie-wikimedia+188 -02.5.1-wmf6: bugfix and Gerrit 2.16 support
integration/zuulpatch-queue/debian/jessie-wikimedia+1 -1Remove /p/ from /info/refs call
integration/zuuldebian/jessie-wikimedia+28 -0Remove /p/ from /info/refs call
Customize query in gerrit

Related Objects
Search...

Event Timeline

Paladox created this task.Jan 27 2019, 11:21 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2019, 11:21 PM
Paladox added a project: Release-Engineering-Team.Jan 27 2019, 11:22 PM
Paladox added a comment.Jan 27 2019, 11:26 PM

See https://gerrit-review.googlesource.com/c/gerrit/+/211752/16//COMMIT_MSG#10 /p/ is optional for this call.

Paladox assigned this task to hashar.Feb 15 2019, 7:19 PM
Paladox triaged this task as Medium priority.

Assigning to @hashar as he needs to do the zuul upgrade.

Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team. · View Herald TranscriptFeb 15 2019, 7:19 PM
Paladox added a parent task: T200739: Upgrade to Gerrit 2.16.13.Feb 15 2019, 7:19 PM
gerritbot added a subscriber: gerritbot.Feb 19 2019, 9:40 PM

Change 491641 had a related patch set uploaded (by Paladox; owner: Paladox):
[integration/zuul@debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/491641

gerritbot added a project: Patch-For-Review.Feb 19 2019, 9:40 PM
Paladox added a parent task: T218844: Update Gerrit /r/p/ links to /r/.Mar 24 2019, 1:27 AM
gerritbot added a comment.Apr 4 2019, 12:39 PM

Change 501201 had a related patch set uploaded (by Hashar; owner: Paladox):
[integration/zuul@patch-queue/debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/501201

gerritbot added a comment.Apr 4 2019, 12:40 PM

Change 491641 abandoned by Hashar:
Remove /p/ from /info/refs call

Reason:
I manage all the patches in the git branch patch-queue/debian/jessie-wikimedia then use git buildpackage to export them to debian/jessie-wikimedia as files in debian/patches/ :)

Anyway thank you. I have moved it with https://gerrit.wikimedia.org/r/#/c/integration/zuul/ /501201/

https://gerrit.wikimedia.org/r/491641

gerritbot added a comment.Apr 4 2019, 12:41 PM

Change 501201 merged by Hashar:
[integration/zuul@patch-queue/debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/501201

gerritbot added a comment.Apr 4 2019, 2:06 PM

Change 501325 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/zuul@debian/jessie-wikimedia] 2.5.1-wmf6: bugfix and Gerrit 2.16 support

https://gerrit.wikimedia.org/r/501325

hashar added a subtask: T208426: Deploy Zuul 2.5.1-wmf6.Apr 4 2019, 2:09 PM
hashar reassigned this task from hashar to Paladox.Apr 4 2019, 2:13 PM
hashar added a project: Upstream.

Would be nice to upstream the fix :]

gerritbot added a comment.Apr 4 2019, 2:45 PM

Change 501325 merged by jenkins-bot:
[integration/zuul@debian/jessie-wikimedia] 2.5.1-wmf6: bugfix and Gerrit 2.16 support

https://gerrit.wikimedia.org/r/501325

hashar closed this task as Resolved.EditedApr 8 2019, 12:27 PM

I have upgraded Zuul to 2.5.1-wmf6 (T208426).

hashar closed subtask T208426: Deploy Zuul 2.5.1-wmf6 as Resolved.Apr 8 2019, 12:30 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL