refs call
Closed, ResolvedPublic
Actions

Description

We need to remove /p/ from https://github.com/openstack-infra/zuul/blob/2.6.0/zuul/connection/gerrit.py#L411 seeing as in gerrit 2.16 /p/<project>/info/refs breaks but it works when removing /p/ from the url.

Details

Related Gerrit Patches:

integration/zuul : debian/jessie-wikimedia	2.5.1-wmf6: bugfix and Gerrit 2.16 support
integration/zuul : patch-queue/debian/jessie-wikimedia	Remove /p/ from /info/refs call
integration/zuul : debian/jessie-wikimedia	Remove /p/ from /info/refs call

Related Objects
Search...

Status	Assigned	Task
Resolved	Dzahn	T165620 Upload gerrit package to stretch apt.wm.org repo
Resolved	Dzahn	T168562 Reimage gerrit2001 as stretch
Resolved	Dzahn	T176532 Gerrit is failing to connect to db on gerrit2001 thus preventing systemd from working
Open	None	T195280 New Gerrit UI does not contain copyable Change-Id or parent commit id
Open	None	T186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits
Resolved	Paladox	T200310 "Included groups" do not appear in New gerrit UI
Open	None	T201246 Make a PolyGerrit plugin to welcome new users
Open	None	T206453 Big empty space under patch description
Open	None	T131968 Outgoing and recently closed reviews that have new comments should be marked as bold just as the incoming reviews
Stalled	None	T103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations
Open	None	T210515 context links in diff don't use pointer cursor
Open	Paladox	T214068 Display Zuul status of jobs for a change on Gerrit UI
Resolved	Paladox	T214631 Create a plugin that add's recheck as a button to PolyGerrit's ui
Open	None	T217174 Deploy multi-site plugin to cobalt and gerrit2001
Open	None	T220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+)
Open	None	T180297 Allow searching for 'state:active', 'state:read_only', 'state:hidden' via web interface
		Restricted Task
Stalled	None	T211139 Convert Gerrit to use H2 as the database
Open	None	T223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch
Open	thcipriani	T200739 Upgrade to Gerrit 2.16.13
Resolved	Paladox	T218844 Update Gerrit /r/p/ links to /r/
Resolved	Paladox	T214807 Patch zuul to remove /p/ from /info/refs call
Resolved	• hashar	T208426 Deploy Zuul 2.5.1-wmf6

Event Timeline

Paladox created this task.Jan 27 2019, 11:21 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 27 2019, 11:21 PM

Paladox added a project: Release-Engineering-Team.Jan 27 2019, 11:22 PM

See https://gerrit-review.googlesource.com/c/gerrit/+/211752/16//COMMIT_MSG#10 /p/ is optional for this call.

Assigning to @hashar as he needs to do the zuul upgrade.

Restricted Application edited projects, added Release-Engineering-Team (Kanban); removed Release-Engineering-Team. · View Herald TranscriptFeb 15 2019, 7:19 PM

Paladox added a parent task: T200739: Upgrade to Gerrit 2.16.13.Feb 15 2019, 7:19 PM

Change 491641 had a related patch set uploaded (by Paladox; owner: Paladox):
[integration/zuul@debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/491641

gerritbot added a project: Patch-For-Review.Feb 19 2019, 9:40 PM

Paladox added a parent task: T218844: Update Gerrit /r/p/ links to /r/.Mar 24 2019, 1:27 AM

Change 501201 had a related patch set uploaded (by Hashar; owner: Paladox):
[integration/zuul@patch-queue/debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/501201

Change 491641 abandoned by Hashar:
Remove /p/ from /info/refs call

Reason:
I manage all the patches in the git branch patch-queue/debian/jessie-wikimedia then use git buildpackage to export them to debian/jessie-wikimedia as files in debian/patches/ :)

Anyway thank you. I have moved it with https://gerrit.wikimedia.org/r/#/c/integration/zuul/ /501201/

https://gerrit.wikimedia.org/r/491641

Change 501201 merged by Hashar:
[integration/zuul@patch-queue/debian/jessie-wikimedia] Remove /p/ from /info/refs call

https://gerrit.wikimedia.org/r/501201

Change 501325 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/zuul@debian/jessie-wikimedia] 2.5.1-wmf6: bugfix and Gerrit 2.16 support

https://gerrit.wikimedia.org/r/501325

• hashar added a subtask: T208426: Deploy Zuul 2.5.1-wmf6.Apr 4 2019, 2:09 PM