Page MenuHomePhabricator

Commons link constraint does not support Data: namespace (tabular data and geographic shape data types)
Closed, ResolvedPublic

Description

As an editor, I only want to constraint violations if a statement is actually incorrect.

Problem:
Currently, any property of type tabular data or geographic shape with a “commons link” constraint will result in a constraint violation, since CommonsLinkChecker does not know the Data: namespace.

Example:

(both of these examples may become invalid in the future, of course, especially the sandbox item)

BDD
GIVEN I am logged in
WHEN I look at a statement of type “geographic shape” or “tabular data”
AND the statement’s property has a “commons link” constraint (query of such properties)
THEN I do not see a constraint violation (unless the value is actually not well-formed, e. g. uses _ instead of )

Acceptance criteria:

  • CommonsLinkChecker recognizes the Data: namespace

Event Timeline

Change 486876 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for Data namespace on Commons

https://gerrit.wikimedia.org/r/486876

Change 486876 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add support for Data namespace on Commons

https://gerrit.wikimedia.org/r/486876

Change 501492 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseQualityConstraints@master] WIP: Make CommonsLinkChecker use the Commons API to asses if page exists

https://gerrit.wikimedia.org/r/501492

Change 501492 had a related patch set uploaded (by Noa wmde; owner: Noa wmde):
[mediawiki/extensions/WikibaseQualityConstraints@master] Make CommonsLinkChecker use the Commons API to asses if page exists

https://gerrit.wikimedia.org/r/501492

Change 501492 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Make CommonsLinkChecker use the Commons API to assess if page exists

https://gerrit.wikimedia.org/r/501492