Page MenuHomePhabricator

PHP7 beta features not in private wikis (due to WikimediaEvents not loaded)
Closed, DeclinedPublic

Description

I couldn't find php7 options in beta features tab on a private wiki. @MarcoAurelio couldn't, and Krenair couldn't on other private wiki.

Is it intentional to skip private wikis or is it just an oversight?

Event Timeline

revi created this task.Jan 28 2019, 10:03 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 28 2019, 10:03 PM

The code for this beta feature is provided through the WikimediaEvents extension which is intentionally not loaded on private wikis. Though we could theoretically move it to somewhere else, I don't think the extra coverage we'd reach (beyond the Debug browser extension) is worth it.

Aklapper renamed this task from PHP7 beta features not in private wikis to PHP7 beta features not in private wikis (due to WikimediaEvents not loaded).Jan 29 2019, 5:48 PM

The code for this beta feature is provided through the WikimediaEvents extension which is intentionally not loaded on private wikis. Though we could theoretically move it to somewhere else, I don't think the extra coverage we'd reach (beyond the Debug browser extension) is worth it.

Plus maybe we don't want test code on private wikis without proper security audits, etc. to avoid potential data leaks?

Joe added a subscriber: Joe.Feb 6 2019, 8:58 AM

I'm absolutely fine with private wikis not having the beta enabled, even though I don't see real security concerns. Marking as declined as I'm not going to fix this.

Joe closed this task as Declined.Feb 6 2019, 8:58 AM