Page MenuHomePhabricator
Create Task
Maniphest T214887

[Story] edit summaries for Schemas
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

As an editor I want good edit summaries in order to understand the edit that was made.

Problem:
Currently there are a lot of fixme or nonsense edit summaries.

Example:
https://wikidata-shex.wmflabs.org/w/index.php?title=Schema:O1&diff=17&oldid=10

BDD
WHEN I edit a Schema
THEN I want to have a text input to add a meaningful edit summary
AND I want to see that summary in the history, recent changes, etc.

Acceptance criteria:

  • the text from that input is shown in the history, recent changes, etc.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Add edit summary field to SchemaEditActionmediawiki/extensions/WikibaseSchemamaster+35 -7
Customize query in gerrit

Related Objects
Search...

StatusSubtypeAssignedTask
 ResolvedLydia_PintscherT214887 [Story] edit summaries for Schemas
 InvalidNoneT215396 Add summary field to edit page for schemas

Event Timeline

Lydia_Pintscher created this task.Jan 29 2019, 9:00 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2019, 9:00 AM
Lydia_Pintscher triaged this task as High priority.Jan 29 2019, 9:01 AM
Lydia_Pintscher moved this task from Backlog to Ready to pick up on the EntitySchema board.
Michael mentioned this in T214310: Resolve (initial) TechDebt of WikibaseSchema.Jan 29 2019, 10:57 AM
Michael updated the task description. (Show Details)Feb 5 2019, 5:43 PM
Lydia_Pintscher updated the task description. (Show Details)Feb 6 2019, 8:48 AM
Lucas_Werkmeister_WMDE subscribed.Feb 6 2019, 10:00 AM
  • implement translatable automatic summaries for editing labels/descriptions/aliases T214466
    • doesn’t have to detect which part was actually edited, at least not for now
  • implement translatable automatic summaries for editing schema text, in addition to custom summary (edited schema: bla bla)
    • add summary field to edit page
Lucas_Werkmeister_WMDE mentioned this in T214466: identifying information for a shape expression.Feb 6 2019, 10:00 AM
Lucas_Werkmeister_WMDE added a comment.Feb 6 2019, 10:18 AM

For now, this task is only about adding a summary field to the “edit” page (after the label/description/aliases fields have been removed there, see T214466). The automatic / translatable part is part of other tasks.

Lucas_Werkmeister_WMDE set the point value for this task to 5.Feb 6 2019, 10:18 AM
Lydia_Pintscher updated the task description. (Show Details)Feb 11 2019, 8:16 AM
Lydia_Pintscher renamed this task from edit summaries for Schemas to [Story] edit summaries for Schemas.Feb 24 2019, 3:37 PM
Lucas_Werkmeister_WMDE closed subtask T215396: Add summary field to edit page for schemas as Invalid.Feb 25 2019, 2:28 PM
Lucas_Werkmeister_WMDE mentioned this in T215396: Add summary field to edit page for schemas.
Lucas_Werkmeister_WMDE edited projects, added Shape Expressions Sprint 3; removed EntitySchema.
hoo claimed this task.Feb 25 2019, 6:00 PM
hoo moved this task from Backlog to Doing on the Shape Expressions Sprint 3 board.
gerritbot subscribed.Mar 6 2019, 11:58 PM

Change 494859 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Add edit summary field to SchemaEditAction

https://gerrit.wikimedia.org/r/494859

gerritbot added a project: Patch-For-Review.Mar 6 2019, 11:58 PM
Lucas_Werkmeister_WMDE added projects: Story, Shape Expressions Sprint 4.Mar 11 2019, 2:08 PM
Lucas_Werkmeister_WMDE removed a project: Story.
Lucas_Werkmeister_WMDE moved this task from Backlog to Doing on the Shape Expressions Sprint 4 board.
hoo moved this task from Doing to Peer Review on the Shape Expressions Sprint 4 board.Mar 15 2019, 12:45 AM
gerritbot added a comment.Mar 21 2019, 12:53 PM

Change 494859 had a related patch set uploaded (by Hoo man; owner: Hoo man):
[mediawiki/extensions/WikibaseSchema@master] Add edit summary field to SchemaEditAction

https://gerrit.wikimedia.org/r/494859

gerritbot added a comment.Mar 25 2019, 1:04 PM

Change 494859 merged by jenkins-bot:
[mediawiki/extensions/WikibaseSchema@master] Add edit summary field to SchemaEditAction

https://gerrit.wikimedia.org/r/494859

hoo added a comment.Mar 25 2019, 1:33 PM

Shall we also do this for the special page in the "Message way" or don't we care?

Lucas_Werkmeister_WMDE added a project: Shape Expressions Sprint 5.Mar 25 2019, 2:07 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Peer Review on the Shape Expressions Sprint 5 board.
Lucas_Werkmeister_WMDE added a comment.Mar 25 2019, 3:43 PM

I think we can skip that.

hoo removed hoo as the assignee of this task.Mar 25 2019, 6:47 PM
hoo moved this task from Peer Review to Verification on the Shape Expressions Sprint 5 board.
hoo subscribed.

Moving this to verification… done for now, the rest is T218893 and follow-ups.

Lydia_Pintscher closed this task as Resolved.Apr 1 2019, 9:18 AM
Lydia_Pintscher claimed this task.
Lydia_Pintscher moved this task from Verification to Done on the Shape Expressions Sprint 5 board.

\o/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits