Page MenuHomePhabricator
Create Task
Maniphest T214919

Prevent redirecting an entity to itself - using Special:RedirectEntity
Closed, ResolvedPublic
Actions

Description

See parent task for further details: T214775

BDD
GIVEN an entity
WHEN trying to redirect it to itself via Special:RedirectEntity
THEN the redirect should be prevented
AND an error message shown ("Can not redirect an Entity to itself")

Acceptance criteria:

  • Redirecting entities to themselves is no longer possible

Details

SubjectRepoBranchLines +/-
Do not let redirecting to self in EntityRedirectCreationInteractormediawiki/extensions/Wikibasemaster+18 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Addshore triaged this task as High priority.Jan 29 2019, 2:28 PM
Addshore created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 29 2019, 2:28 PM
Ladsgroup claimed this task.Jan 29 2019, 3:09 PM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJan 29 2019, 3:09 PM
gerritbot subscribed.Jan 29 2019, 3:21 PM

Change 487041 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/Wikibase@master] Do not let redirecting to self in EntityRedirectCreationInteractor

https://gerrit.wikimedia.org/r/487041

gerritbot added a project: Patch-For-Review.Jan 29 2019, 3:21 PM
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 29 2019, 3:21 PM
gerritbot added a comment.Jan 30 2019, 10:56 AM

Change 487041 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Do not let redirecting to self in EntityRedirectCreationInteractor

https://gerrit.wikimedia.org/r/487041

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 30 2019, 11:00 AM
Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jan 30 2019, 11:02 AM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Jan 30 2019, 11:45 AM
Addshore closed this task as Resolved.Jan 31 2019, 3:01 PM
Addshore moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

Verified on beta

image.png (439×816 px, 25 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL