Page MenuHomePhabricator

[BUG] Leaflet and image z-index is higher than the pop-up box
Closed, ResolvedPublic2 Estimated Story PointsBUG REPORT

Description

Current behavior

image.png (980×1 px, 179 KB)
image.png (850×2 px, 169 KB)

Expected behavior

The pop-up box is over-layed on top of the image.

Event Timeline

Niharika created this task.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Niharika renamed this task from Leaflet and image z-index is higher than the pop-up box to [BUG] Leaflet and image z-index is higher than the pop-up box.Feb 5 2019, 10:08 PM
Niharika set the point value for this task to 2.Feb 7 2019, 12:14 AM
Niharika moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.

I'm not able to replicate this. Is it still happening?

I can only replicate this on Safari but not on Chrome and Firefox. I guess that makes this a lesser priority. I'd still like to have this fixed. Check the email I sent about browserstack to see how you can test this. If it seems like a lot of work, we can drop it.

Niharika lowered the priority of this task from Medium to Low.Mar 8 2019, 12:12 AM

The library Leaflet has map zoom icons set to z-index: 800. By default, the .uls-menu class has z-index 1000, and .oo-ui-dialog has z-index 4. Safari/IE renders the Leaflet zoom icon on top of .uls-menu and .oo-ui-dialog, which is due to how different browsers render the elements according to their position. We are overriding the z-index for .uls-menu and .oo-ui-dialog with higher values to force the elements to display on top of the zoom icon on all browsers. In IE/Safari, the .oo-ui-dialog will not render on top of the Leflet zoom icon with any value less than 1000, and the .uls-menu need a value greater than 1000. We increased the .uls-menu z-index to 1020 to make sure that it renders on top of every element.

This is now on the staging site; ready for QA.

This has been included in v0.9.1 and is in production.

dom_walden subscribed.

I tested that the Translation/ULS dropdown and error popups appear over all other elements on the page (including the SVG image) on:

  • Mojave; Safari 12
  • High Sierra; Safari 11.1.2
  • Sierra; Safari 10.1.2
  • El Capitan; Safari 9.1.3
  • Win7 IE11

I have not seen any regressions when I have been testing other SVG Translate tickets on Firefox.

Restricted Application changed the subtype of this task from "Task" to "Bug Report". · View Herald TranscriptMay 16 2019, 11:01 PM