Page MenuHomePhabricator
Create Task
Maniphest T214971

Popups: Raise test coverage for the new reference preview type
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

Placeholder ticket for patches that do nothing but touching tests (a.k.a. "technical stories"). They have all been created with a user story in mind, but don't actually solve a story.

Acceptance criteria:

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix incomplete test coverage for referencePreview renderermediawiki/extensions/Popupsmaster+34 -0
Move test for escaped URLs into seperate checkmediawiki/extensions/Popupsmaster+16 -1
Add test for dwelling reference links inside a reference previewmediawiki/extensions/Popupsmaster+21 -0
Add tests for the reference preview fade effectmediawiki/extensions/Popupsmaster+28 -4
Tests for the code deciding on the general gateway typemediawiki/extensions/Popupsmaster+51 -0
Factor out gateway selectionmediawiki/extensions/Popupsmaster+42 -11
Rename page gateway filemediawiki/extensions/Popupsmaster+3 -3
Fix a series of issues with misdetected reference elementsmediawiki/extensions/Popupsmaster+44 -14
Add missing HTML escaping to all existing page preview typesmediawiki/extensions/Popupsmaster+76 -13
Customize query in gerrit

Event Timeline

thiemowmde created this task.Jan 30 2019, 3:52 PM
gerritbot subscribed.Jan 30 2019, 3:53 PM

Change 486522 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix a series of issues with misdetected reference elements

https://gerrit.wikimedia.org/r/486522

gerritbot added a project: Patch-For-Review.Jan 30 2019, 3:53 PM
gerritbot added a comment.Jan 30 2019, 3:56 PM

Change 486844 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Add missing HTML escaping to all existing page preview types

https://gerrit.wikimedia.org/r/486844

thiemowmde triaged this task as Medium priority.Jan 30 2019, 4:00 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Backlog to Doing on the Reference Previews board.Jan 30 2019, 4:02 PM
thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2019-01-23 board.
gerritbot added a comment.Jan 30 2019, 5:38 PM

Change 486844 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add missing HTML escaping to all existing page preview types

https://gerrit.wikimedia.org/r/486844

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Jan 30 2019, 6:00 PM
gerritbot added a comment.Jan 31 2019, 9:36 AM

Change 486522 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix a series of issues with misdetected reference elements

https://gerrit.wikimedia.org/r/486522

gerritbot added a comment.Jan 31 2019, 1:23 PM

Change 487351 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Rename page gateway file

https://gerrit.wikimedia.org/r/487351

gerritbot added a comment.Jan 31 2019, 1:23 PM

Change 487352 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Factor out gateway selection

https://gerrit.wikimedia.org/r/487352

gerritbot added a comment.Jan 31 2019, 2:19 PM

Change 487351 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Rename page gateway file

https://gerrit.wikimedia.org/r/487351

gerritbot added a comment.Jan 31 2019, 2:30 PM

Change 487355 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Tests for the code deciding on the general gateway type

https://gerrit.wikimedia.org/r/487355

gerritbot added a comment.Feb 1 2019, 9:50 AM

Change 487352 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Factor out gateway selection

https://gerrit.wikimedia.org/r/487352

gerritbot added a comment.Feb 1 2019, 9:55 AM

Change 487355 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Tests for the code deciding on the general gateway type

https://gerrit.wikimedia.org/r/487355

thiemowmde updated the task description. (Show Details)Feb 1 2019, 11:52 AM
pmiazga added a project: Web-Team-Backlog-Archived (Tracking).Feb 5 2019, 2:52 PM
• Lea_WMDE moved this task from Doing to Ready for pickup on the Reference Previews board.Mar 6 2019, 9:10 AM
WMDE-Fisch added a project: WMDE-QWERTY-Season-Sprint-2019-03-20.Mar 20 2019, 1:09 PM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch removed a project: Patch-For-Review.
WMDE-Fisch updated the task description. (Show Details)Mar 20 2019, 1:11 PM
WMDE-Fisch updated the task description. (Show Details)Mar 20 2019, 1:15 PM
WMDE-Fisch set the point value for this task to 8.
WMDE-Fisch moved this task from Backlog to Doing on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.Mar 21 2019, 2:09 PM
• Lea_WMDE moved this task from Ready for pickup to Doing on the Reference Previews board.Mar 21 2019, 2:58 PM
gerritbot added a comment.Mar 21 2019, 4:06 PM

Change 498139 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Add tests for the reference preview fade effect

https://gerrit.wikimedia.org/r/498139

gerritbot added a project: Patch-For-Review.Mar 21 2019, 4:06 PM
WMDE-Fisch updated the task description. (Show Details)Mar 21 2019, 4:08 PM
gerritbot added a comment.Mar 22 2019, 4:29 PM

Change 498422 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Test ReferencePreview read link links to correct target

https://gerrit.wikimedia.org/r/498422

WMDE-Fisch updated the task description. (Show Details)Mar 22 2019, 4:31 PM
gerritbot added a comment.Mar 25 2019, 10:15 AM

Change 498795 had a related patch set uploaded (by WMDE-Fisch; owner: WMDE-Fisch):
[mediawiki/extensions/Popups@master] Add test for dwelling reference links inside a reference preview

https://gerrit.wikimedia.org/r/498795

WMDE-Fisch claimed this task.Mar 25 2019, 10:19 AM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Doing to Review on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.
gerritbot added a comment.Mar 25 2019, 12:48 PM

Change 498139 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add tests for the reference preview fade effect

https://gerrit.wikimedia.org/r/498139

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.23; 2019-03-26); removed MW-1.33-notes (1.33.0-wmf.16; 2019-02-05).Mar 25 2019, 1:01 PM
gerritbot added a comment.Mar 25 2019, 3:21 PM

Change 498795 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Add test for dwelling reference links inside a reference preview

https://gerrit.wikimedia.org/r/498795

gerritbot added a comment.Mar 26 2019, 1:25 PM

Change 498422 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Move test for escaped URLs into seperate check

https://gerrit.wikimedia.org/r/498422

WMDE-Fisch closed this task as Resolved.Mar 26 2019, 3:00 PM
WMDE-Fisch updated the task description. (Show Details)
WMDE-Fisch moved this task from Review to Done on the WMDE-QWERTY-Season-Sprint-2019-03-20 board.
gerritbot added a comment.Mar 26 2019, 3:58 PM

Change 499232 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] Fix incomplete test coverage for referencePreview renderer

https://gerrit.wikimedia.org/r/499232

gerritbot added a comment.Mar 26 2019, 4:16 PM

Change 499232 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Fix incomplete test coverage for referencePreview renderer

https://gerrit.wikimedia.org/r/499232

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits