I guess this is changing this line, so I can go for it. The new message may be something similar to (A)...

= Warning: You are not logged in.
= Your IP address will be recorded in the edit history of this entity.
+ You might want to [[Special:UserLogin|log in]] or [[Special:CreateAccount|create an account]].

... or (B)...

+ You might want to [[Special:CreateAccount|create an account]] and [[Special:UserLogin|log in]].

... or (C)...

+ You might want to [[Special:UserLogin|log in]].

... or, based on this, (D)...

+ You are encouraged to [[Special:CreateAccount|create an account]] and [[Special:UserLogin|log in]].

... or (E)...

+ You are encouraged to [[Special:UserLogin|log in]].

What do you think?

Charlie/Hanna: input please :)

Hey @abian, you are absolutely right. Thanks for making this ticket!

I would suggest having the same text that is already used on Wikipedia to keep things consistent.

[[Q11135|IP address]]

[[Special:UserLogin|log in]]

[[Special:CreateAccount|create an account]]

other benefits: I tried to find the equivalent on wikidata and couldn't. It seems though that all other wikis have a page like this: https://www.wikidata.org/wiki/Q5851462
I'd add the text anyway (for consistency reasons) and not link it anywhere for now but it would probably be a good idea to add a Wikidata:Why create an account? page at some point.

Okay. :-) About [[Q11135|IP address]], do you think it would be better to link the Wikipedia article corresponding to the language of the message? The Wikidata entity is probably not so human-readable and shows less information.

@abian could we force the link to open in a new tab? Because on Wikipedia it currently open in the same one. That I would find very intrusive because in that instance we'd be forcing the editor to change the wiki which can be disorienting and disruptive to their workflow.

The second question is, what if in the language of the message there is no wikipedia article? Would it automatically revert to the fallback language or show a redlink (have a fallback language)?

Id's stick with the Wikidata item unless we can have the extra tab AND we don't get a redlink.

Edit: okay I just checked there's a 103 language articles for IP-Address but that still leaves a few without so the concern is relevant.

In T215039#4934382, @Charlie_WMDE wrote:

@abian could we force the link to open in a new tab?

Meh, you're right, I didn't think about this. It should be possible by adding https://www.mediawiki.org/wiki/Snippets/Open_specific_external_links_in_new_window to https://www.wikidata.org/wiki/MediaWiki:Common.js.

The second question is, what if in the language of the message there is no wikipedia article? Would it automatically revert to the fallback language or show a redlink (have a fallback language)?

If the link is a part of the message, translators could decide. Another option is leaving "IP address" as it is right now, without a link. I'm also a bit afraid that some clicks can be lost in links that aren't entirely clarifying or relevant instead of getting people to create an account, but I guess there is no perfect solution...

Meh, you're right, I didn't think about this. It should be possible by adding https://www.mediawiki.org/wiki/Snippets/Open_specific_external_links_in_new_window to https://www.wikidata.org/wiki/MediaWiki:Common.js.

if that's an easy fix i'm all for it

If the link is a part of the message, translators could decide. Another option is leaving "IP address" as it is right now, without a link. I'm also a bit afraid that some clicks can be lost in links that aren't entirely clarifying or relevant instead of getting people to create an account, but I guess there is no perfect solution...

you're right. I think i'd just like to keep things as consistent as possible regarding cross-mediawiki features because we already have so much different things going on everywhere which makes switching wikis unnecessarily confusing.

I say let's go for it. We have a project explaining things. Let's link to it when it's helpful. If it opens in a separate tab I see no harm.

Cool! @Charlie_WMDE, sadly I'm not an interface administrator but you with your staff account should be able to give yourself the flag, add the snippet to the Common.js and remove the flag. According to https://www.wikidata.org/wiki/Wikidata:Interface_administrators, "Users with staff accounts can add or remove the flag from their own account".

Hey @abian, I'm not aware of any such rights. @Lydia_Pintscher do you know how to best proceed from here?

If you don't feel comfortable changing permissions, we could ask an interface administrator if they would mind adding the code snippet.

@abian That's a really good idea. I'm petty sure I don't have any interface rights. Is there a way to address all of them without having to ping the lot? Otherwise I could ask @Ladsgroup

That snippet is overly commplicated. Something like this would just work:

$( '#Context a').each( function() { $( this ).attr('target', '_blank') } );

Is it okay for you @abian ?

@Ladsgroup, what would #Context be?

In T215039#4947081, @abian wrote:

@Ladsgroup, what would #Context be?

In our case .mw-notification-tag-wikibase-anonymouseditwarning (Here it's class and not id). So it would be:

$( '.mw-notification-tag-wikibase-anonymouseditwarning a').each( function() { $( this ).attr('target', '_blank') } );

Okay! Thanks.

Done!

Change 491057 had a related patch set uploaded (by Abián; owner: Abián):
[mediawiki/extensions/Wikibase@master] Complete message suggesting to create an account

https://gerrit.wikimedia.org/r/491057

This seems to be blocked by T216374.

+2'ed

Change 491057 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Complete message suggesting to create an account

https://gerrit.wikimedia.org/r/491057