GraphQL extension should use -composer jobs in CI
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	dbarratt
	Feb 1 2019, 12:36 AM

Description

Problem
In 474477 I'm creating a new extension that has Composer dependencies. In the tests, the dependencies are installed (with composer install) however, when the tests are run, Composer's autoloader is not included even when load_composer_autoloader is set to true.

Details

	Subject	Repo	Branch	Lines +/-
	Autoload Composer dependencies in GraphQL extension.	integration/config	master	+1 -1

Customize query in gerrit

Event Timeline

dbarratt created this task.Feb 1 2019, 12:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2019, 12:36 AM

Paladox subscribed.Feb 1 2019, 12:37 AM

That's not the problem. The problem is that your extension needs to use the -composer job variants instead of the vendor ones, so that composer dependencies are pulled in when PHPUnit tests are run.

Legoktm renamed this task from Jenkins does not load Composer's autoloader even if load_composer_autoloader is set to true to GraphQL extension should use -composer jobs in CI.Feb 1 2019, 1:51 AM

Change 487534 had a related patch set uploaded (by Dbarratt; owner: Dbarratt):
[integration/config@master] Autoload Composer dependencies in GraphQL extension.

https://gerrit.wikimedia.org/r/487534

gerritbot added a project: Patch-For-Review.Feb 1 2019, 8:58 PM

dbarratt added a project: GraphQL.Feb 1 2019, 8:59 PM

dbarratt moved this task from Backlog to In Progress on the GraphQL board.

Change 487534 merged by jenkins-bot:
[integration/config@master] Autoload Composer dependencies in GraphQL extension.

https://gerrit.wikimedia.org/r/487534

Legoktm closed this task as Resolved.Feb 3 2019, 4:46 AM

Legoktm assigned this task to dbarratt.