Family.from_url() fails if multiple sites have different paths but same domain
Open, HighPublicBUG REPORT
Actions

Assigned To

None

Authored By

	Xqt
	Feb 1 2019, 8:05 PM

Description

wowwiki is a SubdomainFamily. After moving the domain from wikia.com to fandom.com all sites has the same domain wowwiki.fandom.com and but the paths are different like

wowwiki.fandom.com/de
wowwiki.fandom.com/fr

using the script path.

Family.from_URL() doesn't work in this case because self._hostname(code)[1] == parsed.netloc always match for different sites and the method fails.

See family_tests.TestFamilyUrlRegex.test_each_family
https://integration.wikimedia.org/ci/job/pywikibot-core-tox-nose-docker/5341/console

Related Objects
Search...

Status	Subtype	Assigned	Task
Resolved		Xqt	T245350 Drop support of MW <1.19
Declined		Xqt	T214009 several tests on Fandom are failing
Open	BUG REPORT	None	T215077 Family.from_url() fails if multiple sites have different paths but same domain

Event Timeline

Xqt created this task.Feb 1 2019, 8:05 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptFeb 1 2019, 8:05 PM

Xqt triaged this task as Medium priority.Feb 1 2019, 8:05 PM

Xqt raised the priority of this task from Medium to High.Feb 1 2019, 8:13 PM

Looks like a good candidate for tests

Dvorapa subscribed.Feb 9 2019, 5:51 AM

Same for lyricwiki which now has 'en' and 'ru' subdomains.

Xqt changed the subtype of this task from "Task" to "Bug Report".Apr 15 2019, 3:37 AM

Dvorapa awarded a token.Mar 19 2020, 8:42 PM

Dvorapa added a parent task: T214009: several tests on Fandom are failing.Mar 19 2020, 8:45 PM

Family.from_url() fails if multiple sites have different paths but same domainOpen, HighPublicBUG REPORTActions

Description

Related ObjectsSearch...

Event Timeline

Family.from_url() fails if multiple sites have different paths but same domain
Open, HighPublicBUG REPORT
Actions

Related Objects
Search...