Page MenuHomePhabricator

Hovering over main page shows error preview
Closed, DeclinedPublic

Description

Previously (likely over a year ago) hovering over a link to the Main page didn't display a page preview. Given a recent change (Ie15487184a7f9fc08603fc42cfad3aeac6642dcc) upstream in the REST base endpoint, a broken page preview is displaying

Screen Shot 2019-02-01 at 1.33.02 PM.png (322×523 px, 59 KB)

I see three obvious options for how to handle this:

  1. Special handling for main page (show a special type of preview) - this would likely be a 5-8 story pointer
  2. Client should be updated to show no preview when the main page is shown - this would likely be a 2 story pointer
  3. Do nothing (while looking a little broken, it is still functional and doing nothing has zero cost.

@alexhollender lemme know what's best.

Event Timeline

As noted at T214974#4927834, https://gerrit.wikimedia.org/r/#/c/mediawiki/services/mobileapps/+/404510/ isn't actually a recent change and probably wasn't the proximate cause of the breakage.

For posterity, it looks like what happened here is that an edit to the rarely-edited enwiki beta main page triggered a RESTBase summary regeneration, which hadn't happened since before the mainpage summary type was introduced (in Jan 2018).

I don't remember clearly what the rationale was for adding the mainpage type, and it doesn't appear to be documented. I think it was intended as a kind of hint to clients about why the extracts provided would be (likely) empty. If that's not useful and there's no other strong product reason to flag main pages, it's probably best taken out.

ovasileva subscribed.
In T215080#4938612, @alexhollender wrote:

I'm fine with leaving this as is.

Same here. Based on our guidelines for generic preview, I think this is expected behavior. Closing this for now.

Same here. Based on our guidelines for generic preview, I think this is expected behavior.

I dont quite follow this. For generic previews we show previews but main page links at time of writing is showing the error preview...

I understand declining on the basis that main page links are uncommon but not in this context...

Same here. Based on our guidelines for generic preview, I think this is expected behavior.

I dont quite follow this. For generic previews we show previews but main page links at time of writing is showing the error preview...

I understand declining on the basis that main page links are uncommon but not in this context...

My bad, I didn't read the copy, it's the generic preview "looks like there isn't a preview for this page" that should appear. I still feel like the two are close enough in meaning however, and this is quite a rare case.

I understand declining on the basis that main page links are uncommon

This was my thinking. Plus the current behavior doesn't seem particularly broken.