Page MenuHomePhabricator

ambox styles should have flipped icons for RTL
Closed, InvalidPublic

Description

ambox-style icons should be different version for RTL (for example: mw-ui-icon-minerva-issue-severity-low-lowColor class should have flipped icon)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdlrobson triaged this task as Medium priority.
Jdlrobson moved this task from Needs analysis to Next up on the Readers-Web-Backlog (Design) board.
Jdlrobson added a subscriber: Jdlrobson.

Is this still relevant?
Should it be prioritized?

  • I believe yes - there is special RTL version for example in skins.minerva.content.styles.images but not in skins.minerva.icons.page.issues.uncolored as far as I see.
  • I believe it is generally low priority.

{F34500213}Thanks @eranroz for the update

@Volker_E presumably this can get fixed by us getting these icons into the icon packs in OOUI (T252977). Should we wait for that, or do we want a short term solution here and throw in the RTL equivalents inside the Minerva repo for now?

@Jdlrobson These icons have never been aligned to follow newer icon guidelines, also the brush one is multicolor, which isn't supported in OOUI currently.

More importantly, @eranroz it's doubtful that this icon needs to be flipped. Icons that are symbolizing real world objects to be held in the right hand (going with majority of folks here) aren't flipped. See as another example our edit pencil.

The brush is possibly on the wrong side right now, but we've gathered feedback for above rule by several RTL native speakers.

Aklapper added a subscriber: alexhollender.

Removing task assignee due to inactivity, as this open task has been assigned for more than two years (see emails sent to assignee on May26 and Jun17, and T270544). Please assign this task to yourself again if you still realistically [plan to] work on this task - it would be very welcome!

(See https://www.mediawiki.org/wiki/Bug_management/Assignee_cleanup for tips how to best manage your individual work in Phabricator.)

ovasileva moved this task from Discuss further to Untag on the Readers-Web-Backlog (Tracking) board.
ovasileva added a subscriber: ovasileva.

@Jdlrobson These icons have never been aligned to follow newer icon guidelines, also the brush one is multicolor, which isn't supported in OOUI currently.

More importantly, @eranroz it's doubtful that this icon needs to be flipped. Icons that are symbolizing real world objects to be held in the right hand (going with majority of folks here) aren't flipped. See as another example our edit pencil.

The brush is possibly on the wrong side right now, but we've gathered feedback for above rule by several RTL native speakers.

Resolving based on this comment