Page MenuHomePhabricator

+2 for Zoranzoki21 in mediawiki/*
Closed, DeclinedPublic

Description

I would like to (again) nominate myself for +2 in mediawiki/* repositories.

I requesting +2, so I can help others in this area. I will merge patches only from other users (no patches made by myself). I would not merge patches for which I am not sure are they correct and 100% works.

I am most active here on Phabricator and Gerrit.

My merged patches: https://gerrit.wikimedia.org/r/#/q/owner:%22Zoranzoki21%22+status:merged


Some of complicated commits that I authored - e.g. more than typo fixes or rote commits (per T206927#4663913):

  1. https://gerrit.wikimedia.org/r/472865 (merged)
  2. https://gerrit.wikimedia.org/r/474480 (merged too)

Event Timeline

Kizule created this task.Feb 2 2019, 11:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 2 2019, 11:53 PM

While I'm not involved in deciding this, I would appreciate you doing actual code contributions first. The commits you linked here are still more on the trivial side of things.

Kizule updated the task description. (Show Details)Feb 3 2019, 12:26 AM

(removed the smiley from description because I would not to it sound like some kind of provocation that is not the point)

While I'm not involved in deciding this, I would appreciate you doing actual code contributions first. The commits you linked here are still more on the trivial side of things.

Thanks for comment! Can I get an interpretation on which "actual code contributions" you think? I would be grateful for it. Thanks for understading!

Krenair closed this task as Declined.EditedFeb 3 2019, 2:18 AM
Krenair added a subscriber: Krenair.

I have to agree, adding a few comments with @covers does not come close to the generally expected requirements for this.
To answer your question about what would qualify as an actual code contribution you should at least be altering the logic used in the code that gets run by the wiki.

If another current mediawiki/* +2 holder disagrees, feel free to reopen.