Page MenuHomePhabricator

Remove graphite data for nodepool
Closed, ResolvedPublic

Description

Nodepool has been phased out from production. Its statsd metrics can thus be entirely removed from Graphite. The hierarchy should starting with nodepool..

Details

Related Gerrit Patches:

Event Timeline

hashar triaged this task as Medium priority.Feb 4 2019, 3:29 PM
hashar created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2019, 3:29 PM
greg added a subscriber: greg.Feb 4 2019, 4:33 PM

Doesn't the data just fall out after a while?

Yes they are automatically garbage collected after 15 days:

modules/role/manifests/graphite/production.pp
# Nodepool, which has several metrics for each of the Jenkins jobs
graphite::whisper_cleanup { 'graphite-nodepool':
    directory => "${storage_dir}/whisper/nodepool",
    keep_days => 15,
}

I would like a double check to make sure they all got erased from disk :)

Change 488017 had a related patch set uploaded (by Hashar; owner: Hashar):
[operations/puppet@production] graphite: nodepool is gone, drop whisper_cleanup

https://gerrit.wikimedia.org/r/488017

Indeed the directory/metrics aren't there anymore:

graphite1004:~$ ls -la /srv/carbon/whisper/nodepool
ls: cannot access '/srv/carbon/whisper/nodepool': No such file or directory
graphite2003:~$ ls -la /srv/carbon/whisper/nodepool
ls: cannot access '/srv/carbon/whisper/nodepool': No such file or directory

Change 488017 merged by Filippo Giunchedi:
[operations/puppet@production] graphite: nodepool is gone, drop whisper_cleanup

https://gerrit.wikimedia.org/r/488017

fgiunchedi closed this task as Resolved.Feb 5 2019, 2:29 PM
fgiunchedi claimed this task.

Patch merged, thanks @hashar !