[Bug] Hovering over references in reference previews dismisses dialog
Closed, ResolvedPublic3 Estimated Story Points
Actions

Assigned To

Authored By

	• Niedzielski
	Feb 4 2019, 7:51 PM

Description

Steps to reproduce

visit http://localhost:8181/wiki/Middle_English on the Vector desktop site with reference previews enabled.
Hover over "[4]".
In the reference preview that appears, hover over "[3]".

Expected results

Reference preview should remain unchanged.

Actual results

Reference preview disappears.

Peek 2019-02-04 12-47.gif (954×1 px, 1 MB)

Environments observed

Browser version: Chromium v71.0.3578.98
OS version: Ubuntu v18.10
Device model: Desktop
Device language: English
Git commit: fb56a2e

Details

	Subject	Repo	Branch	Lines +/-
	Exclude links in popups to trigger other popups	mediawiki/extensions/Popups	master	+3 -3

Customize query in gerrit

Related Objects

Mentioned In: T215419: Clicking on links to the same page inside of a reference preview
Mentioned Here: rEPOPfb56a2e729da: Mark reference preview content area as "mw-parser-output"

Event Timeline

• Niedzielski created this task.Feb 4 2019, 7:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2019, 7:51 PM

• Niedzielski renamed this task from [Bug] Hovering over references in reference previews dismiss dialog to [Bug] Hovering over references in reference previews dismisses dialog.Feb 4 2019, 7:52 PM

Lea_WMDE triaged this task as Medium priority.Feb 5 2019, 1:43 PM

Lea_WMDE moved this task from Backlog to Ready for pickup on the Reference Previews board.

Jdlrobson edited projects, added Web-Team-Backlog (Tracking); removed Web-Team-Backlog.Feb 5 2019, 3:35 PM

Note that for now it was decided that we do not want to support popups in popups. So the desired behavior here should be:

Hovering over the footnote inside of the popup should not close the popup. But should also not trigger another popup.

WMDE-Fisch moved this task from Ready for pickup to Doing on the Reference Previews board.Feb 6 2019, 2:09 PM

• jkroll claimed this task.Feb 6 2019, 2:16 PM

• jkroll moved this task from Sprint Backlog to Doing on the WMDE-QWERTY-Sprint-2019-02-06 board.

WMDE-Fisch mentioned this in T215419: Clicking on links to the same page inside of a reference preview .Feb 6 2019, 2:25 PM

Change 488910 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/Popups@master] [WIP] Exclude links in popups to trigger other popups

https://gerrit.wikimedia.org/r/488910

gerritbot added a project: Patch-For-Review.Feb 7 2019, 11:33 AM

thiemowmde removed • jkroll as the assignee of this task.Feb 11 2019, 1:17 PM

thiemowmde moved this task from Doing to Review on the WMDE-QWERTY-Sprint-2019-02-06 board.

thiemowmde added a subscriber: • jkroll.

Change 488910 merged by jenkins-bot:
[mediawiki/extensions/Popups@master] Exclude links in popups to trigger other popups

https://gerrit.wikimedia.org/r/488910

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 12 2019, 1:00 PM

WMDE-Fisch moved this task from Review to Demo on the WMDE-QWERTY-Sprint-2019-02-06 board.Feb 12 2019, 4:28 PM

Lea_WMDE closed this task as Resolved.Feb 20 2019, 9:00 AM

Lea_WMDE claimed this task.

Lea_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2019-02-06 board.

[Bug] Hovering over references in reference previews dismisses dialogClosed, ResolvedPublic3 Estimated Story PointsActions