Page MenuHomePhabricator

Remove binding to wikibase-datamodel and wikibase-datamodel-services
Closed, DeclinedPublic

Description

Binding to Wikibase Datamodel services introduces subtle and spread out, but large costs. The reason is that this added another consumer to that library which increases the cost of making (breaking) changes to it.

The suggested approach is to review which code is actually needed from these libraries and then copy that to code to WikibaseSchema. The rationale is that even a few hundred lines of extra code are less extra cost than binding to Wikibase Datamodel and Wikibase Datamodel Services.

Event Timeline

Michael edited projects, added Shape Expressions Sprint 1; removed EntitySchema.

We decided to create a patch based on this ticket in a pair programming session. This patch can then be better discussed, and we can decide whether we want to go that way.

This turned out to be more than 1k lines of code not including tests. We decided not to use this in favour of taking a lighter weight approach.