Page MenuHomePhabricator
Create Task
Maniphest T215261

The RevisionRepository should not throw MW exception and exception signature should be consistent with interface
Closed, InvalidPublic
Actions

Description

RevisionRepository
More documentation and missing exception and return type
Be careful with MW exception so not to bind to MW.

Details

SubjectRepoBranchLines +/-
Consistent exceptions from RevisionSchemaRepositorymediawiki/extensions/WikibaseSchemamaster+62 -11
Customize query in gerrit

Related Objects
Search...

Event Timeline

Michael created this task.Feb 5 2019, 11:52 AM
Michael edited projects, added Shape Expressions Sprint 1; removed EntitySchema.Feb 5 2019, 1:26 PM
Michael claimed this task.Feb 5 2019, 4:10 PM
Restricted Application added a project: User-Michael. · View Herald TranscriptFeb 5 2019, 4:10 PM
Michael moved this task from Backlog to Doing on the Shape Expressions Sprint 1 board.Feb 5 2019, 4:10 PM
gerritbot subscribed.Feb 5 2019, 4:15 PM

Change 488086 had a related patch set uploaded (by Michael Große; owner: Michael Große):
[mediawiki/extensions/WikibaseSchema@master] Consistent exceptions from RevisionSchemaRepository

https://gerrit.wikimedia.org/r/488086

gerritbot added a project: Patch-For-Review.Feb 5 2019, 4:15 PM
Michael moved this task from 🗃️ Incoming to ⏳ In progress on the User-Michael board.Feb 5 2019, 4:22 PM
gerritbot added a comment.Feb 7 2019, 5:04 PM

Change 488086 abandoned by Michael Große:
Consistent exceptions from RevisionSchemaRepository

Reason:
We decided that we are not going to use a Repository

https://gerrit.wikimedia.org/r/488086

Dinoguy1000 renamed this task from The RevisionRepository should not throw MW exception and exception signature should be consisten with interface to The RevisionRepository should not throw MW exception and exception signature should be consistent with interface .Feb 7 2019, 7:40 PM
Michael closed this task as Invalid.Feb 8 2019, 10:57 AM

We decided to no longer go with a repository. See T215516: Implement SchemaWriter to replace current repository and T215512: Create a parser Service for parsing JSON data into Schema structures instead.

Michael moved this task from Doing to Done on the Shape Expressions Sprint 1 board.Feb 8 2019, 10:58 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL