Page MenuHomePhabricator

Padlocks don't display on mobile (Wikimedia Commons)
Open, Needs TriagePublic

Description

Please see: https://commons.wikimedia.org/w/index.php?title=Commons:Village_pump/Technical&oldid=337795329#The_new_padlocks_don't_show_up_on_mobile

The page protection padlocks don't see to display on the mobile version of the wikibrowser.

Developer notes

Example URI:
https://commons.m.wikimedia.org/w/index.php?title=User_talk:Dr._Bernd_Gross&action=edit&mobileaction=toggle_view_mobile

".fmbox" are treated like page issues and subject to ambox rules per https://www.mediawiki.org/wiki/Recommendations_for_mobile_friendly_articles_on_Wikimedia_wikis#Making_page_issues_(ambox_templates)_mobile_friendly

The code for page issues incorrectly identifies them as page issues. Removing "fmbox" class from the template would be the quickest way to solve this.

Luckily the page is still usable.

Event Timeline

DonTrung created this task.Feb 5 2019, 1:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 5 2019, 1:30 PM
zhuyifei1999 added a subscriber: zhuyifei1999.

This is caused by https://commons.wikimedia.org/w/load.php?debug=true&lang=en&modules=skins.minerva.content.styles&only=styles&skin=minerva (matches .content a > img)

.content a > img,
.content a > .lazy-image-placeholder,
.content noscript > img {
  max-width: 100% !important;
}

This is caused by https://commons.wikimedia.org/w/load.php?debug=true&lang=en&modules=skins.minerva.content.styles&only=styles&skin=minerva (matches .content a > img)

.content a > img,
.content a > .lazy-image-placeholder,
.content noscript > img {
  max-width: 100% !important;
}

This is not the problem. The problem is the template is being incorrectly identified as a page issue/ambox template. See my notes in the description. I'm not 100% sure how to fix this in the code level right now.. but there are certain short term template fixes that can be made.

.fmbox shouldn't be treated like a page issue because the class is not used for page issues - it is used for edit notices and system messages (see documentation of template here). Treating fmbox as a page issue also breaks things on enwiki e.g on (view logged out)
https://en.m.wikipedia.org/w/index.php?title=Barack_Obama&action=edit&mobileaction=toggle_view_mobile

A not useful "learn more" link is created and the padlock image removed.