Page MenuHomePhabricator

"Depicts walking": Add/edit depicts statements in UploadWizard
Closed, ResolvedPublic

Description

See https://wikimedia.invisionapp.com/share/ZMOI9QK9TKS#/screens/324827163 & https://wikimedia.invisionapp.com/share/NJOIMI9D6SX#/screens/324924548

Acceptance criteria:

https://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

  • User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"
  • Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom
  • Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
  • One can enter depicts statements just like one can on the file page
  • Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)
  • Clicking "publish" submits depicts input and one can see the statements on the file page

QA Results: Run 1

QA Results: Run 2

Related Objects

StatusAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenNone
ResolvedAbit
OpenNone
DuplicateNone
OpenNone
OpenNone
OpenNone
ResolvedRamsey-WMF
ResolvedRamsey-WMF
ResolvedEdtadros
ResolvedEdtadros
ResolvedEdtadros
ResolvedHa78na

Event Timeline

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 5 2019, 5:29 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF renamed this task from "Depicts crawling": Add/edit depicts statements in UploadWizard to "Depicts walking": Add/edit depicts statements in UploadWizard.Feb 5 2019, 5:48 PM
Abit added a subscriber: Abit.Feb 5 2019, 7:30 PM

Change 471919 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Ramsey-WMF triaged this task as High priority.Mar 8 2019, 2:47 AM
Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.

Change 471919 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Change 471919 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

matthiasmullie updated the task description. (Show Details)
Edtadros reassigned this task from Edtadros to matthiasmullie.EditedMar 30 2019, 3:09 AM
Edtadros added a subscriber: Edtadros.

Test Result

Status: : ❌ FAIL
OS: macOS Mojave
Browser: Chrome

Test Artifact(s):

✅ AC1: User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"

✅ AC2: Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom

✅ AC3: Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
See Above

✅ AC4: One can enter depicts statements just like one can on the file page

✅ AC5: Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)

When tried with depicts entered they didn't show up on the File page as expected.

❌ AC6: Clicking "publish" submits depicts input and one can see the statements on the file page
Clicking Publish worked with no depicts:


However, with depicts entered as shown below, clicking Publish (both top and bottom) didn't do anything, it just stayed on the same page.

Edtadros updated the task description. (Show Details)Mar 30 2019, 3:12 AM

QA test failure probably because of T219540.
Will assign back to self and look into Monday.

Test Result: Run 2

Status: : ❌ FAIL
OS: macOS Mojave
Browser: Chrome

@matthiasmullie This is just a different label than what is listed in the QA steps. Functionally everything is working.

Test Artifact(s):

❌ AC1: User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"
The section is labeled "Add data" instead of "Metadata"

✅ AC2: Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom

✅ AC3: Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
See Above

✅ AC4: One can enter depicts statements just like one can on the file page

✅ AC5: Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)
When tried with depicts entered they didn't show up on the File page as expected.

✅ AC6: Clicking "publish" submits depicts input and one can see the statements on the file page

Edtadros updated the task description. (Show Details)Apr 9 2019, 5:11 AM
Edtadros updated the task description. (Show Details)

I'm going to move this out of QA: the label having a different name than in the original acceptance criteria is ok, that changed because of T219945