Page MenuHomePhabricator

"Depicts walking": Add/edit depicts statements in UploadWizard
Closed, ResolvedPublic

Description

See https://wikimedia.invisionapp.com/share/ZMOI9QK9TKS#/screens/324827163 & https://wikimedia.invisionapp.com/share/NJOIMI9D6SX#/screens/324924548

Acceptance criteria:

https://commons.wikimedia.beta.wmflabs.org/wiki/Special:UploadWizard

  • User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"
  • Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom
  • Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
  • One can enter depicts statements just like one can on the file page
  • Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)
  • Clicking "publish" submits depicts input and one can see the statements on the file page

QA Results: Run 1

QA Results: Run 2

Related Objects

StatusSubtypeAssignedTask
Declineddchen
OpenNone
OpenNone
DuplicateNone
OpenFeatureNone
OpenFeatureNone
DuplicateNone
ResolvedNone
ResolvedNone
ResolvedNone
Resolved Ramsey-WMF
Resolved Ramsey-WMF
ResolvedEdtadros
ResolvedEdtadros
ResolvedEdtadros
Resolved Ha78na

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Jdforrester-WMF renamed this task from "Depicts crawling": Add/edit depicts statements in UploadWizard to "Depicts walking": Add/edit depicts statements in UploadWizard.Feb 5 2019, 5:48 PM

Change 471919 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Ramsey-WMF moved this task from Untriaged to Triaged on the Multimedia board.

Change 471919 had a related patch set uploaded (by Matthias Mullie; owner: Matthias Mullie):
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Change 471919 merged by jenkins-bot:
[mediawiki/extensions/UploadWizard@master] Add new metadata step

https://gerrit.wikimedia.org/r/471919

Edtadros subscribed.

Test Result

Status: : ❌ FAIL
OS: macOS Mojave
Browser: Chrome

Test Artifact(s):

✅ AC1: User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"

Screen Shot 2019-03-29 at 7.44.35 PM.png (2×2 px, 1 MB)

✅ AC2: Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom

Screen Shot 2019-03-29 at 7.49.04 PM.png (2×2 px, 1 MB)

✅ AC3: Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
See Above

✅ AC4: One can enter depicts statements just like one can on the file page

Screen Shot 2019-03-29 at 7.51.11 PM.png (2×2 px, 1 MB)

✅ AC5: Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)

Screen Shot 2019-03-29 at 7.52.40 PM.png (2×2 px, 1004 KB)
When tried with depicts entered they didn't show up on the File page as expected.

❌ AC6: Clicking "publish" submits depicts input and one can see the statements on the file page
Clicking Publish worked with no depicts:

Screen Shot 2019-03-29 at 7.58.28 PM.png (2×2 px, 990 KB)

However, with depicts entered as shown below, clicking Publish (both top and bottom) didn't do anything, it just stayed on the same page.
Screen Shot 2019-03-29 at 8.03.51 PM.png (2×2 px, 1 MB)

QA test failure probably because of T219540.
Will assign back to self and look into Monday.

Test Result: Run 2

Status: : ❌ FAIL
OS: macOS Mojave
Browser: Chrome

@matthiasmullie This is just a different label than what is listed in the QA steps. Functionally everything is working.

Test Artifact(s):

❌ AC1: User sees "metadata" step in Special:UploadWizard (in between "describe" and "use"
The section is labeled "Add data" instead of "Metadata"

Screen Shot 2019-04-08 at 9.45.07 PM.png (2×2 px, 1 MB)

✅ AC2: Metadata step has 2 sets of "skip" and "publish" buttons, one on top, one at the bottom

Screen Shot 2019-04-08 at 9.50.53 PM.png (2×2 px, 2 MB)

✅ AC3: Metadata step displays list of uploaded files on the left - clicking one of them displays it's respective image & depicts input form
See Above

✅ AC4: One can enter depicts statements just like one can on the file page

Screen Shot 2019-04-08 at 9.52.20 PM.png (2×2 px, 2 MB)

✅ AC5: Clicking "skip" advances to the next/last step, without submitting the depicts input (if any)
When tried with depicts entered they didn't show up on the File page as expected.

Screen Shot 2019-04-08 at 9.53.39 PM.png (2×2 px, 2 MB)

✅ AC6: Clicking "publish" submits depicts input and one can see the statements on the file page

Screen Shot 2019-04-08 at 10.06.35 PM.png (2×2 px, 2 MB)

Screen Shot 2019-04-08 at 10.06.18 PM.png (2×2 px, 1 MB)

Edtadros updated the task description. (Show Details)

I'm going to move this out of QA: the label having a different name than in the original acceptance criteria is ok, that changed because of T219945