Page MenuHomePhabricator

Add ha78na to `wmf` LDAP group.
Closed, ResolvedPublic

Description

Please add me to the appropriate LDAP group. Pinging also my manager @MarkTraceur

Event Timeline

Ha78na created this task.Tue, Feb 5, 9:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptTue, Feb 5, 9:26 PM
Dzahn added a subscriber: Dzahn.Wed, Feb 6, 6:14 PM

@Ha78na Appropriate group for which task please? Is this about a login to a specific tool?

This is the wmf group request again. We really need to improve the on-boarding documentation. :-(

Dzahn added a comment.Wed, Feb 6, 6:35 PM

@Jdforrester-WMF Yea, but what is it for? I don't see any onboarding ticket or name or what tools are needed?

@Jdforrester-WMF Yea, but what is it for? I don't see any onboarding ticket or name or what tools are needed?

This is the on-boarding task for Hana; T214654 is the one for Eric. Both are staff developers and thus require wmf access to do their job.

From your statement, it sounds like there is meant to be an overall task? @MarkTraceur can't access Phabricator right now but I guess I could make them on his behalf?

Dzahn added a comment.Wed, Feb 6, 6:48 PM

This is the on-boarding task for Hana;

Ok, so i searched email for Hana and found a thread. From this ticket alone there was no way for us to know that though.

Both are staff developers and thus require wmf access to do their job.

So it's about merging things in Gerrit repos and logins on logstash ?

From your statement, it sounds like there is meant to be an overall task?

Not sure, but aren't there other things that need to be done for a new hire besides this group?

This is the on-boarding task for Hana;

Ok, so i searched email for Hana and found a thread. From this ticket alone there was no way for us to know that though.

Totally agreed, we need to improve the on-boarding docs to avoid this.

Both are staff developers and thus require wmf access to do their job.

So it's about merging things in Gerrit repos and logins on logstash ?

Yup, plus all the random other things hung of wmf like pivot/etc.

From your statement, it sounds like there is meant to be an overall task?

Not sure, but aren't there other things that need to be done for a new hire besides this group?

Yes, loads, but none of them (OIT/mailing lists/desk/etc.) generally happen on Phab, IME.

Change 488536 had a related patch set uploaded (by Dzahn; owner: Dzahn):
[operations/puppet@production] admins: add Hana Worku to ldap_only admins

https://gerrit.wikimedia.org/r/488536

Ha78na added a comment.Wed, Feb 6, 7:40 PM

Hey thanks @Jdforrester-WMF for coming to help out and sorry for confusion @Dzahn - I thought you had a way to associate my username and know I worked for foundation as an engineer.

My onboarding checklist had this item:

" if you are a software engineer, request access to the group ldap/wmf, adding your manager to the access request task for approval."

I'm taking notes on things that need to change in the onboarding doc - lmk any more appropriate language or more detailed instructions for how these ldap requests should come in. Keep in mind new folks may not be familiar with phabricator. Having specific guidelines about what title the task should have, who should be tagged, and what info should be in description is helpful.

Change 488536 merged by Dzahn:
[operations/puppet@production] admins: add Hana Worku to ldap_only admins

https://gerrit.wikimedia.org/r/488536

Mentioned in SAL (#wikimedia-operations) [2019-02-06T20:49:00Z] <mutante> LDAP - adding h78na to wmf - welcome Hana Worku, developer on the multimedia team (T215352)

Dzahn added a comment.Wed, Feb 6, 9:00 PM

Totally agreed, we need to improve the on-boarding docs to avoid this.

Thanks, yep. This older ticket comes to mind -> T108131. It would be awesome if we could create these tickets from a Phabricator template link so that users just fill out a form.

I don't mean to make life complicated for you by making these comments, it's really just because we need to figure out a few things before we can resolve such tickets.

Like.. confirm the LDAP user has a wikimedia.org address, what is their real name, are they full time WMF employee or contractor, if contractor what is the end date and who is the contact once it expires.

Yup, plus all the random other things hung of wmf like pivot/etc.

Gotcha, yea that all makes sense. I think at some point we may need more fine-tuned groups rather than stuffing everything in "wmf" and also that "wmf" may be a bad name as it might imply that it's just a label to identify who is an employee. But just like we don't add staff flag on wiki by default we don't do it here. That's why i was asking what it was for.

But these things are of course outside the scope of this ticket and don't worry it won't come up again each time a new person is hired.

Not sure, but aren't there other things that need to be done for a new hire besides this group?

Yes, loads, but none of them (OIT/mailing lists/desk/etc.) generally happen on Phab, IME.

Yea, gotcha. tbh i think that's part of the problem, if we'd all use the same system it would be a lot more obvious what the state of the onboarding is. Or if that isn't possible some kind of semi-automatic notification like an email to Phab. But as above, i don't mean to start such general discussions on specific tickets, so sorry for that. This would probably be part of an onboarding workflow ticket like the one linked above.

Dzahn added a comment.Wed, Feb 6, 9:11 PM

sorry for confusion @Dzahn - I thought you had a way to associate my username and know I worked for foundation as an engineer.

Hey Hana, welcome to WMF and no reason to be sorry, you are the new employee and can expect us to just do it. It shouldn't be your problem. Yes, you are right, i can lookup LDAP users, i's just a little indirect and involves multiple steps. First LDAP user to email in one place, then email to real name in another and then searching email for a welcome thread that matches it.

I'm taking notes on things that need to change in the onboarding doc - lmk any more appropriate language or more detailed instructions for how these ldap requests should come in.

It's much appreciated that you do that. Maybe we could add that the following bits are helpful on the ticket:

  • LDAP user name
  • real name
  • status (full time employee / contractor)
    • if contractor, what is the end/renewal date of the contract
  • department / team

Keep in mind new folks may not be familiar with phabricator. Having specific guidelines

Definitely! I refer to my comment above to James, maybe we can turn this into a Phabricator form like we do for a few other things. That would mean new users just have to fill out a form rather than having to type free form text.

Dzahn closed this task as Resolved.Wed, Feb 6, 9:13 PM
Dzahn claimed this task.

@Ha78na Resolved! you have been added to ldap/wmf. Everything that relies on it should work now.

Change 488753 had a related patch set uploaded (by Effie Mouzeli; owner: Effie Mouzeli):
[operations/puppet@production] admin: fixed typo in username ha78na

https://gerrit.wikimedia.org/r/488753

jijiki reopened this task as Open.Thu, Feb 7, 4:59 AM

Change 488753 merged by Dzahn:
[operations/puppet@production] admin: fixed typo in username ha78na

https://gerrit.wikimedia.org/r/488753

jijiki closed this task as Resolved.Thu, Feb 7, 5:06 AM