| cmadeo | |
| Feb 5 2019, 9:53 PM |
| F28217093: IMG_3150.PNG | |
| Feb 14 2019, 3:53 PM |
| F28217105: IMG_3151.PNG | |
| Feb 14 2019, 3:53 PM |
| F28217097: IMG_3147.PNG | |
| Feb 14 2019, 3:53 PM |
| F28217101: IMG_3149.PNG | |
| Feb 14 2019, 3:53 PM |
| F28159424: 01 Toolbar v3.png | |
| Feb 8 2019, 7:51 PM |
| F28159425: 02 Toolbar v3.png | |
| Feb 8 2019, 7:51 PM |
We have a hunch that folks are going to want to find a specific word or phrase very quickly, and giving them fast access to Find in Page would help with this.
Move Find in page to the first view of the toolbar
| First view | Second view |
|---|---|
 |  |
| Zeplin: https://zpl.io/V1zmKgE | Zeplin: https://zpl.io/VQKxjzA |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • JMinor | T209168 Wikitext editing tools | |||
| Resolved | • NHarateh_WMF | T209173 Editing toolbar: As an editor on the iOS app, I would like to be able to easily insert Wikitext syntax | |||
| Resolved | • NHarateh_WMF | T214398 Editing toolbar: Find in page | |||
| Resolved | • NHarateh_WMF | T215357 Move the Find in Page icon to the first view of the toolbar |
Sorry, just realized that the icon for template is being set to 'active' but as this is not a toggle state, we should remove the active state for the template icon. Moving this back to blocked or waiting
@cmadeo so the template button should never be highlighted? The template button in the Text formatting panel is implemented in the same way, right now you can 'toggle' the template by adding or removing {{}}
@NHarateh_WMF Sorry, I'm getting confused. But based on this ticket (https://phabricator.wikimedia.org/T211617) I think you're correct and I'm incorrect. We would need to update the other icons in the toolbar to be set to selected (link, citation, etc) though to match.
@cmadeo no problem! Here's what I'm seeing when I try to edit today's featured article on enwiki, Chains of Love -
Template icon is highlighted when the cursor's in a template
Link icon is not highlighted when the cursor is in a link that's inside a template (this should be fixed)
Citation icon is highlighted when the cursor is in a <ref> tag
Link icon is highlighted when the cursor is in a link
So the only icon that's not selected that I'm seeing is the link in a template