Page MenuHomePhabricator

Unit tests of Jade extensions failing
Closed, DeclinedPublic

Description

https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/33777/console

There were 5 failures:

1) Jade\Tests\JudgmentPageWikitextRendererTest::testCentralUser
Failed asserting that '__NOTOC__
== Not damaging and Good faith * ==


=== Endorsements ===
{| class="wikitable"
! User
! Endorsement

|-
| ⧼0⧽
| 

|}



' matches PCRE pattern "/\[\[User:TestUser 63c808.00f\]\]/".

/workspace/src/extensions/JADE/tests/phpunit/JudgmentPageWikitextRendererTest.php:188
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

2) Jade\Tests\JudgmentValidatorTest::testValidateEndorsementUsers_goodCid
Failed asserting that false is true.

/workspace/src/extensions/JADE/tests/phpunit/JudgmentValidatorTest.php:335
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

3) Jade\Tests\JudgmentValidatorTest::testValidateEndorsementUsers_suppressedCid
Failed asserting that false is true.

/workspace/src/extensions/JADE/tests/phpunit/JudgmentValidatorTest.php:374
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

4) Jade\Tests\JudgmentValidatorTest::testValidateEndorsementUsers_idMismatch
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'jade-user-id-mismatch'
+'jade-user-central-id-invalid'

/workspace/src/extensions/JADE/tests/phpunit/JudgmentValidatorTest.php:449
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

5) WikimediaEvents\Tests\PageViewsTest::testLog
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
     0 => false
     1 => false
-    2 => 1
-    3 => 2
+    2 => 10
+    3 => 1
     4 => ''
     5 => 'cfd7b71f77926f0a399e521d6abf4...98cf2b'
     6 => 'cfd7b71f77926f0a399e521d6abf4...98cf2b'
     7 => '/w/index.php'
     8 => 'search=7aa6bac48446ff434aa0fc...dacted'
     9 => '0'
     10 => 'GET'
     11 => 'edit'
 )

/workspace/src/tests/phpunit/MediaWikiTestCase.php:2052
/workspace/src/extensions/WikimediaEvents/tests/phpunit/PageViewsTest.php:518
/workspace/src/tests/phpunit/MediaWikiTestCase.php:424
/workspace/src/maintenance/doMaintenance.php:94

There is also a test from WikimediaEvents, but that is also filled under T215219