Page MenuHomePhabricator

npm is failing with eslint on Kartographer extension
Closed, ResolvedPublic

Description

https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/76369/console

Running "eslint:all" (eslint) task

/src/modules/util/util.js
  1:12  error  'require' is defined but never used  no-unused-vars

✖ 1 problem (1 error, 0 warnings)

In my opinion a sub-dependency must changed, which introduce the breaking change for the CI. The last merge passed without such problems.
The eslint-config must be stable when new versions for the dependency are created to avoid breaking CI.

Event Timeline

Change 488978 had a related patch set uploaded (by MSantos; owner: MSantos):
[mediawiki/extensions/Kartographer@master] Eslint have some issues with commented code

https://gerrit.wikimedia.org/r/488978

Change 488978 merged by jenkins-bot:
[mediawiki/extensions/Kartographer@master] Eslint have some issues with commented code

https://gerrit.wikimedia.org/r/488978

MSantos claimed this task.
MSantos removed a project: Patch-For-Review.