Page MenuHomePhabricator

CRM contribution tracking writing should have a switch to use the new infrastructure
Open, NormalPublic4 Story Points

Description

When this switch is on, processes within the CRM which write new rows to contribution_tracking should get new IDs from the sequence generator. We will have to investigate whether it will be better to continue writing rows directly to the database, or send messages to the new queue.

Writing rows to the DB might be necessary in order to change less code, but could also result in out-of-order ID inserts - is that a problem?

Event Timeline

Ejegg created this task.Feb 6 2019, 9:15 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 6 2019, 9:15 PM
mepps added a subscriber: mepps.Mar 28 2019, 2:08 PM

@Ejegg would we both write to the db and use a queue?

Ejegg added a comment.Mar 28 2019, 3:04 PM

@mepps We would do either one or the other. I'm leaning towards doing just the queue messages for the sake of code consistency and order of inserts.

The queue consumer should also be able to update existing rows, e.g. to add a contribution id to the row.

mepps added a subscriber: XenoRyet.Apr 24 2019, 3:46 PM

@XenoRyet did I remember you talking about this yesterday in standup or was it another part of contribution_tracking?

@mepps This is the civi side of it, I was talking about the Donation Interface side.

DStrine set the point value for this task to 4.May 14 2019, 8:10 PM

Change 510608 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@deployment] WIP switch for using contribution tracking queue

https://gerrit.wikimedia.org/r/510608

Change 510757 had a related patch set uploaded (by Ejegg; owner: Ejegg):
[wikimedia/fundraising/crm@master] WIP switch for using contribution tracking queue

https://gerrit.wikimedia.org/r/510757

Change 510608 abandoned by Ejegg:
WIP switch for using contribution tracking queue

Reason:
oops, this was against deployment

https://gerrit.wikimedia.org/r/510608

Ejegg claimed this task.May 30 2019, 4:42 AM
Ejegg triaged this task as Normal priority.