Page MenuHomePhabricator

[Bug] Closing editor overlay shows loading spinner indefinitely
Closed, ResolvedPublic

Description

Steps to reproduce

  1. Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Dog on the MinervaNeue mobile site.
  2. Tap edit (the plain mobile editor not the visual editor).
  3. Tap the close cross.

Expected results

  • Editor overlay closes.

Actual results

  • Editor overlay closes but shows a loading spinner forever.
    en.m.wikipedia.beta.wmflabs.org_wiki_Dog.png (1×1 px, 961 KB)

Environments observed

  • Browser version: Chromium v71.0.3578.98
  • OS version: Ubuntu v18.10
  • Device model: Desktop
  • Device language: English

Check any additional observations

Not present on enwiki prod.

Event Timeline

Change 488591 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] mobile.init/editor: Don't create loading overlay if we're not going to use it

https://gerrit.wikimedia.org/r/488591

Change 488591 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@wmf/1.33.0-wmf.16] mobile.init/editor: Don't create loading overlay if we're not going to use it

https://gerrit.wikimedia.org/r/488591

This looks fixed to me. Not sure if editing team would like to do any testing so leaving resolving this task to them.