Page MenuHomePhabricator

User::getCacheKey immediately overwrites parameter
Closed, ResolvedPublic

Description

	/**
	 * @since 1.27
	 * @param WANObjectCache $cache
	 * @return string
	 */
	protected function getCacheKey( WANObjectCache $cache ) {
		$cache = MediaWikiServices::getInstance()->getMainWANObjectCache();
		$lbFactory = MediaWikiServices::getInstance()->getDBLoadBalancerFactory();

		return $cache->makeGlobalKey( 'user', 'id', $lbFactory->getLocalDomainID(), $this->mId );
	}

$cache is passed in to getCacheKey, but isn't used, and is immediately overridden in the function body

Details

Event Timeline

Change 488711 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Stop overwriting $cache in User::getCacheKey()

https://gerrit.wikimedia.org/r/488711

Change 488711 merged by jenkins-bot:
[mediawiki/core@master] Stop overwriting $cache in User::getCacheKey()

https://gerrit.wikimedia.org/r/488711

Reedy claimed this task.
Reedy removed a project: Patch-For-Review.