Page MenuHomePhabricator

Clicking the "Beta" button takes you right to the bottom of the beta features preferences pane instead of the top
Open, NormalPublic

Description

The following issue is technically not limited to the Beta features tab, but happens with all tabs on the preferences page. However, we typically don't link directly to one of these tabs. BetaFeatures as well as the cog wheel in Page-Previews are very prominent places where this issue becomes visible.

Steps to reproduce:

  1. Go to any page, e.g. User:Deskana
  2. Click "Beta" at the top right of the page

Expected:

  • You're taken to the beta features page in your preferences, and the screen is either at the top of the page, or at the start of the Beta section.

Actual:

  • You're taken to the beta features page in your preferences, and the screen scrolls a few times before stopping at the bottom of the page.

Tested in both Chrome and Firefox on Windows 7.

Event Timeline

Deskana created this task.Feb 7 2019, 10:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2019, 10:01 AM
Deskana edited projects, added BetaFeatures; removed Beta-Feature.Feb 7 2019, 10:07 AM

@Lea_WMDE here is the phab task for the issue I mentioned to you

thiemowmde triaged this task as Normal priority.Mar 12 2019, 5:03 PM
thiemowmde added a project: Page-Previews.
thiemowmde updated the task description. (Show Details)

@Volker_E, you have been involved in the OOUI-ification of the preferences page. Do you have an idea how this could possibly be solved?

Is this a Regression of what was reported as T192769: Special:Preferences: OOUI tabs cause a FOUC because the PHP side doesn't hack in their HTML, unlike the non-OOUI tabs a year ago?

Yesterday, OOUI 0.31.0 was released: https://gerrit.wikimedia.org/r/plugins/gitiles/oojs/ui/+/v0.31.0/History.md. It introduces server-side versions of all the layouts used by [[Special:Preferences]] (namely IndexLayout and TabPanelLayout, currently created in mediawiki.special.preferences.ooui/tabs.js). This will allow a rewrite of [[Special:Preferences]] so that more stuff is done server-side, and possibly resolve this issue as well. The ticket for this is, from what I understand, T215645: Factor out the hard-coded magic for knitting together the PHP and JS side of TabLayout as built for Special:Preferences so others can use it.