adjust spacing between Sense ID, bar and Gloss
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Lydia_Pintscher
	Feb 7 2019, 11:43 AM

Description

Problem:
The spacing around the bar that divides Sense ID and Gloss is too small. It should be the same as the spacing around the bar separating Form ID and Representation.

Example:

https://www.wikidata.org/wiki/Lexeme:L21966

Screenshots:

Acceptance criteria:

Spacing between Sense ID and bar are the same as between Form ID and bar

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Add 9px padding to glosses	mediawiki/extensions/WikibaseLexeme	master	+1 -0

Customize query in gerrit

Related Objects

Mentioned In: rEWLE14a834b94772: Add 9px padding to glosses
rEWLEacb2fd08bae6: Add 0px padding to glosses
rEWLE6d154bc80c29: Adjust spacing between Sense ID, bar and Gloss
rEWLE6af379dea550: it checkout T215502

Event Timeline

Lydia_Pintscher created this task.Feb 7 2019, 11:43 AM

Restricted Application added a project: Wikidata. · View Herald TranscriptFeb 7 2019, 11:43 AM

Lydia_Pintscher triaged this task as Medium priority.Feb 7 2019, 11:43 AM

Lydia_Pintscher moved this task from Incoming to Ready to estimate on the Wikidata-Campsite board.

Lydia_Pintscher moved this task from incoming to consider for next sprint on the Wikidata board.

Lydia_Pintscher moved this task from incoming to features/bugs for next release (Lexeme page) on the Wikidata Lexicographical data board.

Arexnj subscribed.Feb 7 2019, 12:07 PM

A right-margin of 17.5 px is there between the "wikibase-lexeme-form-id" and the bar. There is also a padding of 9 px in the "representation-widget_representation". Please help me on how to proceed with making these changes. I would like to take this task.

Arexnj claimed this task.Feb 7 2019, 12:34 PM

Hey @Arexnj Thank you for working on this!
You need to make changes on https://github.com/wikimedia/mediawiki-extensions-WikibaseLexeme/blob/master/resources/lexeme.less. I don't know if you know how to make gerrit patches but there's a good summary in https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr

Addshore moved this task from consider for next sprint to in progress on the Wikidata board.Feb 7 2019, 3:53 PM

Hey, I have committed my gerrit patch. Kindly review it.
https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/489190/

Change 489383 had a related patch set uploaded (by Arexnj; owner: Arexnj):
[mediawiki/extensions/WikibaseLexeme@master] it checkout T215502

https://gerrit.wikimedia.org/r/489383

gerritbot added a project: Patch-For-Review.Feb 9 2019, 3:21 PM

Arexnj mentioned this in rEWLE6af379dea550: it checkout T215502.Feb 9 2019, 3:23 PM

Change 489383 abandoned by Arexnj:
it checkout T215502

https://gerrit.wikimedia.org/r/489383

Ladsgroup mentioned this in rEWLE6d154bc80c29: Adjust spacing between Sense ID, bar and Gloss.Feb 9 2019, 3:56 PM

@Ladsgroup Thank you for your help sir.

ReleaseTaggerBot added a project: MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 9 2019, 5:00 PM

https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/489190/ is merged :)

Addshore moved this task from To Do (prioritised from top to bottom) to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 12 2019, 3:48 PM

I am trying to test this but failing :/ https://wikidata.beta.wmflabs.org/wiki/Lexeme:L1 seems to be broken because of all the current beta issues. https://test.wikidata.org/wiki/Lexeme:L2 might not have the code yet but not sure. If it has the code already then it's not working as expected. I'll wait until later this week to test again.

For me both have them properly. Maybe you need to clear the browser cache?
testwiki:

Beta:

Thanks! That's what it looks like for me as well. The language is still too close to the bar in your screenshots if you compare it to the space in Forms.

In T215502#4960183, @Lydia_Pintscher wrote:

Thanks! That's what it looks like for me as well. The language is still too close to the bar in your screenshots if you compare it to the space in Forms.

This wasn't covered by the patch or the acceptance criteria. Fixing it would not be hard but it should be clear. I can make a patch to fix it if you want it.

Fair enough. Sorry. And yes please <3

Ladsgroup moved this task from Test (Verification) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 19 2019, 1:49 PM

Change 491490 had a related patch set uploaded (by Ladsgroup; owner: Ladsgroup):
[mediawiki/extensions/WikibaseLexeme@master] Add 0px padding to glosses

https://gerrit.wikimedia.org/r/491490

Ladsgroup mentioned this in rEWLEacb2fd08bae6: Add 0px padding to glosses.Feb 19 2019, 2:30 PM

Ladsgroup mentioned this in rEWLE14a834b94772: Add 9px padding to glosses.Feb 19 2019, 2:46 PM

Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 19 2019, 3:03 PM

Addshore moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Feb 20 2019, 12:31 PM

Change 491490 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Add 9px padding to glosses

https://gerrit.wikimedia.org/r/491490

ReleaseTaggerBot edited projects, added MW-1.33-notes (1.33.0-wmf.19; 2019-02-26); removed MW-1.33-notes (1.33.0-wmf.17; 2019-02-12).Feb 20 2019, 2:00 PM