Regression: Nested references do not work
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Feb 7 2019, 5:26 PM

Description

Caught by browser test. This is blocking merges in Minerva. Nested references are no longer behaving as they should

QA steps

Visit https://en.m.wikipedia.beta.wmflabs.org/wiki/Selenium_References_test_page
Click [note 1] reference.

-A drawer appears:

-Click the reference inside the drawer.

Expected: reference drawer updates
actual: browser navigates to reference (#cite_note-1)

QA Results

Status	Details
✅ Passed	T215536#4946266

Related Objects

Mentioned In: T212521: RFC: Reconsider how we run QUnit unit tests

Event Timeline

Jdlrobson created this task.Feb 7 2019, 5:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 7 2019, 5:26 PM

Jdlrobson triaged this task as High priority.Feb 7 2019, 5:27 PM

Jdlrobson claimed this task.Feb 7 2019, 10:17 PM

Jdlrobson moved this task from To Do to Doing on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.

It looks like this got fixed by @Niedzielski's patch I08c0faaba50037566bef22dd401b3480081ebe60
I am seeing the issue before this patch but not after.

It was broken by @Niedzielski's patch Ic193e97b4cd6f72d226bd9768e904bdec168ba39
Luckily that didn't make the train so no follow ups or SWATs required as it's not included in the current deploy branch! (phew)

Screen Shot 2019-02-07 at 2.26.19 PM.png (425×606 px, 116 KB)

(

Jdlrobson moved this task from Doing to Ready for Signoff on the Web-Team-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3) board.Feb 7 2019, 10:27 PM

@Jdlrobson, sorry for the hassle but I'm glad it's fixed

Jdlrobson mentioned this in T212521: RFC: Reconsider how we run QUnit unit tests.Feb 7 2019, 11:37 PM

Seems like this should first go through QA

ovasileva assigned this task to Edtadros.Feb 8 2019, 10:00 AM

@Edtadros this one does have an automated browser test that is now passing and previously wasn't.
https://integration.wikimedia.org/ci/view/Reading-Web/job/selenium-MinervaNeue/832/ (note the failures in here appear to be for another regression that ill open a ticket for for today)

Is that enough?
Super curious to hear your thoughts on the line between relying on manual and automated QA!

Test Result

Status: ✅ PASS
OS: macOS Mojave
Browser: Chrome DevTools Device Emulator (iPhone X)

Test Artifact(s):
When the reference link [1] in the drawer that opened from [note 1] was clicked, the reference in the drawer updated to the nested reference as seen in the screenshot below: