Page MenuHomePhabricator

Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open
Open, Needs TriagePublic

Description

Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open.

Event Timeline

matmarex created this task.Feb 8 2019, 1:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 8 2019, 1:00 PM
matmarex claimed this task.Feb 8 2019, 1:01 PM
matmarex added a project: VisualEditor.

This is the same kind of issue as T210559. Turns out I only fixed it for some dialogs.

Change 487552 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/MobileFrontend@master] ve.init.mw.MobileFrontendArticleTarget: Disable iOS scrolling hack more aggressively

https://gerrit.wikimedia.org/r/487552

Change 487552 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] ve.init.mw.MobileFrontendArticleTarget: Disable iOS scrolling hack more aggressively

https://gerrit.wikimedia.org/r/487552

Esanders moved this task from Inbox to High Priority on the Editing QA board.Feb 13 2019, 6:46 PM

@Ryasmeen, do the steps below look like the right ones to take to test whether the scroll issue has been resolved? I ask because the bug seems to persist for me (iPhone 7+ | Safari) and considering it's cleared QA, I wonder if there's something I'm missing...

Steps taken:

  1. On iOS, in Safari, navigate to https://en.m.wikipedia.org/wiki/National_Gallery
  2. Tap "Edit" (VisualEditor initiates)
  3. Navigate to a link
  4. Tap the Linking Tool "🔗" in the toolbar
  5. With keyboard closed, attempt to scroll the Linking Dialog (no movement)
  6. With keyboard open, attempt to scroll the Linking Dialog (no movement)

@ppelberg: Hmm yeah I just checked this following the same steps and getting the same behavior as you. I wonder if it regressed back in last 2 weeks, after I verified it on Beta cluster. Pinging @matmarex.
Also, while re-testing this on Beta cluster found out that scrolling in general is not working for any page. Filed this regression: T217985.

This was definitely fixed when I wrote that patch. It seems to have broken in two different ways since then:

  1. Nothing can be scrolled at all (this is the task Rummana filed, T217985)

After that is fixed:

  1. Dialogs still can't be scrolled (Kosta brought it up in the Web teams Google Chat last week, but we did not file a task, I filed it now as T218062)

I suggest we close this task and instead track those two.

(Note that in the issue in this task, dialogs could be scrolled, but you could not scroll to the very end)

Good catch RE T217985, @Ryasmeen.

@matmarex, breaking this out into the two tickets (T217985 & T218062) – as you've done – is great.

In the meantime, it seems like it makes sense to leave this ticket open until we're confident T217985, T218062 and T218352 have been resolved at which point we can re-test.

This is now broken. Reopening.

Ryasmeen moved this task from QA to Incoming on the VisualEditor (Current work) board.

I can't reproduce (testing on https://en.m.wikipedia.org/wiki/The_Fighting_Temeraire).

Video: https://drive.google.com/file/d/1S496riNZy-oOgrB_Wq789MROSGMahw6M/view (too large to upload to Phabricator). I can view and use the last entry in the dialog while the keyboard is open.

It is a bit fiddly due to T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari (if Safari decides to scroll the page behind the dialog, any further swipes will keep scrolling it instead of the dialog, but if you wait until the scrollbar fades out, then you can start scrolling the dialog again – you can see this happen in the video at 15-17 seconds). But with a bit of patience, everything in the dialog is reachable, with keyboard open or not.

I can't reproduce (testing on https://en.m.wikipedia.org/wiki/The_Fighting_Temeraire).
Video: https://drive.google.com/file/d/1S496riNZy-oOgrB_Wq789MROSGMahw6M/view (too large to upload to Phabricator). I can view and use the last entry in the dialog while the keyboard is open.
It is a bit fiddly due to T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari (if Safari decides to scroll the page behind the dialog, any further swipes will keep scrolling it instead of the dialog, but if you wait until the scrollbar fades out, then you can start scrolling the dialog again – you can see this happen in the video at 15-17 seconds). But with a bit of patience, everything in the dialog is reachable, with keyboard open or not.

@matmarex: So, the issue that you mentioned earlier which was causing the fiddly-ness, T212159: Scrolling a ProcessDialog scrolls the page behind on iOS Safari is fixed now right? But I still see that problem of irregular scrolling. And you are right if I wait long enough for the scrollbar to disappear it works, but I feel we should make it more smooth. I am sharing the screen capture to re-consider this.
https://drive.google.com/open?id=135p0oDjdKA7brZT5YqGZd3pXeO4zxFYw

Ryasmeen moved this task from QA to Stalled/Waiting on the VisualEditor (Current work) board.

I agree it's poor but I don't think we can do anything to fix it.