Page MenuHomePhabricator

Missing hook docs
Closed, ResolvedPublic

Description

php findhooks.php

Undocumented: DatabaseOraclePostInit
Undocumented: EditPageBeforeEditToolbar
Undocumented: LocalisationCacheRecache
Undocumented: SkinTemplateNavigation
Undocumented: VectorTemplateToolboxEnd

The authors of these hooks need to update /docs/hooks.txt


Version: 1.16.x
Severity: normal

Details

Reference
bz19564

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 10:40 PM
bzimport set Reference to bz19564.
bzimport added a subscriber: Unknown Object (MLST).
demon created this task.Jul 7 2009, 2:17 PM

(In reply to comment #0)

php findhooks.php

Undocumented: DatabaseOraclePostInit

Undocumented: EditPageBeforeEditToolbar

Did this one in r52843.

Undocumented: LocalisationCacheRecache

Undocumented: SkinTemplateNavigation
Undocumented: VectorTemplateToolboxEnd

These two were already done by Trevor in r52806 and r52814.

demon added a comment.Jul 7 2009, 4:57 PM

Ah, missed those two (accidentally ran findhooks on my branch, not trunk).

brion added a comment.Jul 19 2009, 7:22 PM

Trunk as of r53485:

undocumented: DatabaseOraclePostInit
undocumented: InitPreferencesForm
undocumented: LocalisationCacheRecache
undocumented: PreferencesUserInformationPanel
undocumented: RenderPreferencesForm
undocumented: ResetPreferences
undocumented: SavePreferences
undocumented: SpecialUploadComplete
not found: UploadComplete
not found: UploadVerification

The results I got were different, when I ran it, none of the preferences hooks were in the results.

Updated hooks.txt in r53491. Online docs still need updating:
$ php maintenance/findhooks.php --online
undocumented: DatabaseOraclePostInit
undocumented: EditPage::importFormData
undocumented: EditPageCopyrightWarning
undocumented: EditPageTosSummary
undocumented: LocalisationCacheRecache
undocumented: SkinCopyrightFooter
undocumented: SkinTemplateNavigation
undocumented: SpecialUploadComplete
undocumented: UserLoginMailPassword
not found: AutoAuthenticate
not found: BeforeWatchlist
not found: BrokenLink
not found: EditSectionLinkForOther
not found: InitPreferencesForm
not found: LoadAllMessages
not found: MessageNotInMwNs
not found: PreferencesUserInformationPanel
not found: RenderPreferencesForm
not found: ResetPreferences
not found: SavePreferences
not found: SpecialPageExecuteAfterPage
not found: SpecialPageExecuteBeforeHeader
not found: SpecialPageExecuteBeforePage
not found: SpecialPageGetRedirect
not found: UserrightsChangeableGroups

Updated the maintenance script in r53525 and updated the online docs, should be good now.